make tests pass again

Author: 1-Bart-1

src/filament.jl

@@ -55,7 +55,7 @@ function velocity_3D_bound_vortex!(
         vel .= (gamma / (4π)) .* r1Xr2 ./ (norm(r1Xr2)^2) .* 
             dot(r0, r1r2norm)
     elseif norm(r1Xr0) / norm(r0) == 0
-        vel .= zeros(3)
+        vel .= 0.0
     else
         @debug "inside core radius"
         @debug "distance from control point to filament: $(norm(r1Xr0) / norm(r0))"
@@ -122,7 +122,7 @@ as implemented in KiteAeroDyn".
         vel .= (gamma / (4π)) .* r1Xr2 ./ (norm(r1Xr2)^2) .* 
             dot(r0, normr1r2)
     elseif norm(r1Xr0) / norm(r0) == 0
-        vel .= zeros(3)
+        vel .= 0.0
     else
         # Project onto core radius
         r1_proj = dot(r1, r0) * r0 / (norm(r0)^2) + 
@@ -182,7 +182,7 @@ function velocity_3D_trailing_vortex_semiinfinite!(
         K = GAMMA / (4π) / norm(r1XVf)^2 * (1 + dot(r1, Vf) / norm(r1))
         vel .= K .* r1XVf
     elseif norm(r1XVf) / norm(Vf) == 0
-        vel .= zeros(3)
+        vel .= 0.0
     else
         r1_proj = dot(r1, Vf) * Vf + 
                   epsilon * (r1/norm(r1) - Vf) / norm(r1/norm(r1) - Vf)

src/panel.jl

@@ -364,16 +364,16 @@ Calculate the velocity induced by a vortex ring at a control point.
 - nothing
 """
 @inline function calculate_velocity_induced_single_ring_semiinfinite!(
-    velind::MVector{3, Float64},
-    tempvel::MVector{3, Float64},
+    velind::MVec3,
+    tempvel::MVec3,
     filaments::Vector{Union{VortexStepMethod.BoundFilament, VortexStepMethod.SemiInfiniteFilament}},
-    evaluation_point::MVector{3, Float64},
+    evaluation_point::MVec3,
     evaluation_point_on_bound::Bool,
     va_norm::Float64,
-    va_unit::MVector{3, Float64},
+    va_unit::MVec3,
     gamma::Float64,
     core_radius_fraction::Float64,
-    work_vectors::NTuple{10, MVector{3, Float64}}
+    work_vectors::NTuple{10, MVec3}
 )
     velind .= 0.0
     tempvel .= 0.0
@@ -449,6 +449,7 @@ function calculate_velocity_induced_bound_2D!(
     cross3!(cross_, r0, r3)
 
     # Calculate induced velocity
-    U_2D .= -(cross_ ./ sum(cross_square) ./ 2π) .* norm(r0)
+    cross_square .= cross_.^2
+    U_2D .= (cross_ ./ sum(cross_square) ./ 2π) .* norm(r0)
     return nothing
 end

test/test_wing_aerodynamics.jl

@@ -194,13 +194,14 @@ end
         # Calculate new matrices
         va_norm_array = fill(norm(Uinf), length(coord))
         va_unit_array = repeat(reshape(Uinf ./ norm(Uinf), 1, 3), length(coord))
-        AIC_x, AIC_y, AIC_z = calculate_AIC_matrices(
+        calculate_AIC_matrices!(
             wing_aero,
             "VSM",
             core_radius_fraction,
             va_norm_array,
             va_unit_array
         )
+        AIC_x, AIC_y, AIC_z = wing_aero.AIC[1, :, :], wing_aero.AIC[2, :, :], wing_aero.AIC[3, :, :]
 
         # Compare matrices with higher precision for VSM
         @test isapprox(MatrixU, AIC_x, atol=1e-8)