Skip to content

Commit d449398

Browse files
committed
Remove unimplemented keyword arguments
1 parent 7e588f2 commit d449398

File tree

2 files changed

+9
-25
lines changed

2 files changed

+9
-25
lines changed

src/body_aerodynamics.jl

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ Main structure for calculating aerodynamic properties of bodies.
3737
end
3838

3939
"""
40-
BodyAerodynamics(wings::Vector{T}; aero_center_location=0.25,
41-
control_point_location=0.75,
40+
BodyAerodynamics(wings::Vector{T};
4241
kite_body_origin=zeros(MVec3)) where T <: AbstractWing
4342
4443
Construct a [BodyAerodynamics](@ref) object for aerodynamic calculations.
@@ -47,17 +46,13 @@ Construct a [BodyAerodynamics](@ref) object for aerodynamic calculations.
4746
- `wings::Vector{T}`: Vector of wings to analyze, where T is an AbstractWing type
4847
4948
# Keyword Arguments
50-
- `aero_center_location=0.25`: Chordwise location of aerodynamic center (0-1)
51-
- `control_point_location=0.75`: Chordwise location of control point (0-1)
5249
- `kite_body_origin=zeros(MVec3)`: Origin point of kite body reference frame in CAD reference frame
5350
5451
# Returns
5552
- [BodyAerodynamics](@ref) object initialized with panels and wings
5653
"""
5754
function BodyAerodynamics(
5855
wings::Vector{T};
59-
aero_center_location=0.25,
60-
control_point_location=0.75,
6156
kite_body_origin=zeros(MVec3)
6257
) where T <: AbstractWing
6358
# Initialize panels
@@ -82,35 +77,27 @@ function BodyAerodynamics(
8277
end
8378

8479
body_aero = BodyAerodynamics{length(panels)}(; panels, wings)
85-
init!(body_aero; aero_center_location, control_point_location)
80+
init!(body_aero)
8681
return body_aero
8782
end
8883

8984
"""
90-
init!(body_aero::BodyAerodynamics;
91-
aero_center_location=0.25,
92-
control_point_location=0.75)
85+
init!(body_aero::BodyAerodynamics)
9386
9487
Initialize a BodyAerodynamics struct in-place by setting up panels and coefficients.
9588
9689
# Arguments
9790
- `body_aero::BodyAerodynamics`: The structure to initialize
9891
99-
# Keyword Arguments
100-
- `aero_center_location=0.25`: Chordwise location of aerodynamic center (0-1)
101-
- `control_point_location=0.75`: Chordwise location of control point (0-1)
102-
10392
# Returns
10493
nothing
10594
"""
106-
function init!(body_aero::BodyAerodynamics;
107-
aero_center_location=0.25,
108-
control_point_location=0.75)
95+
function init!(body_aero::BodyAerodynamics)
10996

11097
idx = 1
11198
for wing in body_aero.wings
11299
println("init wing")
113-
init!(wing; aero_center_location, control_point_location)
100+
init!(wing)
114101
panel_props = wing.panel_props
115102

116103
# Create panels

src/wing_geometry.jl

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ Calculate geometric properties for each panel.
9898
# Returns:
9999
[PanelProperties](@ref) containing vectors for each property
100100
"""
101-
function update_panel_properties!(panel_props::PanelProperties, section_list::Vector{Section}, n_panels::Int,
102-
aero_center_loc::Float64, control_point_loc::Float64)
101+
function update_panel_properties!(panel_props::PanelProperties, section_list::Vector{Section}, n_panels::Int)
103102
coords = panel_props.coords
104103
aero_centers = panel_props.aero_centers
105104
control_points = panel_props.control_points
@@ -230,16 +229,14 @@ function Wing(n_panels::Int;
230229
Wing(n_panels, spanwise_distribution, panel_props, spanwise_direction, Section[], Section[], remove_nan)
231230
end
232231

233-
function init!(wing::AbstractWing; aero_center_location::Float64=0.25, control_point_location::Float64=0.75)
232+
function init!(wing::AbstractWing)
234233
refine_aerodynamic_mesh!(wing)
235234

236235
# Calculate panel properties
237-
update_panel_properties!(
236+
@time update_panel_properties!(
238237
wing.panel_props,
239238
wing.refined_sections,
240-
wing.n_panels,
241-
aero_center_location,
242-
control_point_location
239+
wing.n_panels
243240
)
244241
return nothing
245242
end

0 commit comments

Comments
 (0)