Skip to content

Conversation

@1-Bart-1
Copy link
Member

No description provided.

@1-Bart-1 1-Bart-1 marked this pull request as ready for review February 22, 2025 01:50
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 54.16667% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kite_geometry.jl 64.10% 14 Missing ⚠️
src/panel.jl 48.00% 13 Missing ⚠️
src/wing_geometry.jl 25.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/VortexStepMethod.jl 33.33% <ø> (ø)
src/filament.jl 85.71% <ø> (-0.21%) ⬇️
src/wing_geometry.jl 70.64% <25.00%> (-1.30%) ⬇️
src/panel.jl 60.76% <48.00%> (-4.78%) ⬇️
src/kite_geometry.jl 88.00% <64.10%> (-6.90%) ⬇️

@1-Bart-1
Copy link
Member Author

@ufechner7 could you make Xfoil and Distributed a test dependency? I don't know how that works...

@ufechner7
Copy link
Member

It is not clear to me how to test the feat/xfoil branch. What is the input? What is the expected output? How can I run it?

@ufechner7
Copy link
Member

@ufechner7 could you make Xfoil and Distributed a test dependency? I don't know how that works...

I can do this later, it can be merged as is.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 22, 2025 15:31
@1-Bart-1 1-Bart-1 merged commit 23ebc3a into main Feb 22, 2025
6 of 7 checks passed
@1-Bart-1 1-Bart-1 deleted the feat/xfoil branch February 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically generate polar_data from 2d_foil_profile.dat using XFoil.jl

3 participants