Skip to content

Feat/xfoil #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1-Bart-1 merged 22 commits into from
Feb 22, 2025
Merged

Feat/xfoil #43

1-Bart-1 merged 22 commits into from
Feb 22, 2025

Conversation

@1-Bart-1
Copy link
Member

@1-Bart-1 1-Bart-1 commented Feb 20, 2025

No description provided.

@1-Bart-1 1-Bart-1 marked this pull request as ready for review February 22, 2025 01:50
@codecov
Copy link

codecov bot commented Feb 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.16667% with 33 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kite_geometry.jl 64.10% 14 Missing ⚠️
src/panel.jl 48.00% 13 Missing ⚠️
src/wing_geometry.jl 25.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/VortexStepMethod.jl 33.33% <ø> (ø)
src/filament.jl 85.71% <ø> (-0.21%) ⬇️
src/wing_geometry.jl 70.64% <25.00%> (-1.30%) ⬇️
src/panel.jl 60.76% <48.00%> (-4.78%) ⬇️
src/kite_geometry.jl 88.00% <64.10%> (-6.90%) ⬇️

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 22, 2025 02:47
@1-Bart-1 1-Bart-1 linked an issue Feb 22, 2025 that may be closed by this pull request
Automatically generate polar_data from 2d_foil_profile.dat using XFoil.jl #30
Closed
@1-Bart-1
Copy link
Member Author

1-Bart-1 commented Feb 22, 2025

@ufechner7 could you make Xfoil and Distributed a test dependency? I don't know how that works...

@ufechner7
Copy link
Member

ufechner7 commented Feb 22, 2025

It is not clear to me how to test the feat/xfoil branch. What is the input? What is the expected output? How can I run it?

ufechner7
ufechner7 requested changes Feb 22, 2025
View reviewed changes
@ufechner7
Copy link
Member

ufechner7 commented Feb 22, 2025

@ufechner7 could you make Xfoil and Distributed a test dependency? I don't know how that works...

I can do this later, it can be merged as is.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 22, 2025 15:31
@1-Bart-1 1-Bart-1 merged commit 23ebc3a into main Feb 22, 2025
6 of 7 checks passed
@1-Bart-1 1-Bart-1 deleted the feat/xfoil branch February 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ufechner7 ufechner7 Awaiting requested review from ufechner7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically generate polar_data from 2d_foil_profile.dat using XFoil.jl

3 participants

@1-Bart-1 @ufechner7