Merged
Conversation
Codecov ReportAttention: Patch coverage is
|
Member
|
Can you add a script |
Closed
Member
Author
|
AIC matrix calculation and gamma loop have less than 100 allocations each now. Calculate results still has a lot of allocations. Added a test for allocations. |
ufechner7
requested changes
Feb 24, 2025
Member
ufechner7
left a comment
ufechner7
left a comment
There was a problem hiding this comment.
Looks good, only two remarks to address.
src/VortexStepMethod.jl
Outdated
| using Interpolations: linear_interpolation, Line, Extrapolation | ||
| using Serialization | ||
| using SharedArrays | ||
| using BenchmarkTools |
Member
There was a problem hiding this comment.
Why do you want to use BenchmarkTools in the package itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.