Skip to content

Conversation

@1-Bart-1
Copy link
Member

No description provided.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 24, 2025 23:34
@1-Bart-1 1-Bart-1 linked an issue Feb 24, 2025 that may be closed by this pull request
@1-Bart-1
Copy link
Member Author

Moment coefficient and moment calculations around global axes and arbitrary point. Not yet around a specified axis.

@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/body_aerodynamics.jl 92.50% <100.00%> (+0.22%) ⬆️
src/panel.jl 66.91% <ø> (ø)
src/plotting.jl 92.26% <100.00%> (ø)
src/solver.jl 77.77% <100.00%> (ø)

@ufechner7
Copy link
Member

I cannot review that without an agreement on the reference frame(s) we want to use first.

@1-Bart-1
Copy link
Member Author

As I wrote in the comment, these moments are still around the global frame and an arbitrary provided reference point. No need for an extra reference frame. A future pull request will implement the moments around a custom reference frame.

@ufechner7
Copy link
Member

As I wrote in the comment, these moments are still around the global frame and an arbitrary provided reference point. No need for an extra reference frame. A future pull request will implement the moments around a custom reference frame.

Well, I do not know what you mean with "Global frame". We have to agree on the reference frames that we are using before writing such code.

@ufechner7 ufechner7 marked this pull request as draft February 25, 2025 15:03
Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please clarify my three comments.

@ufechner7 ufechner7 marked this pull request as ready for review February 25, 2025 17:13
@1-Bart-1
Copy link
Member Author

Everything is in KB frame.

@1-Bart-1
Copy link
Member Author

I still think KB frame should be the same as CAD frame.

@1-Bart-1 1-Bart-1 requested a review from ufechner7 February 26, 2025 02:52
@ufechner7 ufechner7 merged commit d7c0b37 into main Feb 26, 2025
7 checks passed
@ufechner7 ufechner7 deleted the feat/moment branch March 8, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add moment coefficient calculations around specified point

3 participants