-
Notifications
You must be signed in to change notification settings - Fork 0
Add moment coefficients and moments #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Moment coefficient and moment calculations around global axes and arbitrary point. Not yet around a specified axis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
I cannot review that without an agreement on the reference frame(s) we want to use first. |
|
As I wrote in the comment, these moments are still around the global frame and an arbitrary provided reference point. No need for an extra reference frame. A future pull request will implement the moments around a custom reference frame. |
Well, I do not know what you mean with "Global frame". We have to agree on the reference frames that we are using before writing such code. |
ufechner7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please clarify my three comments.
|
Everything is in KB frame. |
|
I still think KB frame should be the same as CAD frame. |
No description provided.