Skip to content

init! functions #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1-Bart-1 merged 16 commits into from
Feb 28, 2025
Merged

init! functions #73

1-Bart-1 merged 16 commits into from
Feb 28, 2025

Conversation

@1-Bart-1
Copy link
Member

@1-Bart-1 1-Bart-1 commented Feb 26, 2025 •
edited
Loading

Add init! functions to update wing_aero in a less allocating way. Step 1 for dynamically changing segments.

@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.48918% with 52 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/panel.jl 68.49% 23 Missing ⚠️
src/wing_geometry.jl 77.77% 20 Missing ⚠️
src/body_aerodynamics.jl 80.00% 9 Missing ⚠️
Files with missing lines Coverage Δ
src/VortexStepMethod.jl 33.33% <ø> (ø)
src/filament.jl 98.76% <100.00%> (+0.19%) ⬆️
src/kite_geometry.jl 88.00% <100.00%> (ø)
src/plotting.jl 92.52% <100.00%> (ø)
src/wake.jl 100.00% <100.00%> (+7.14%) ⬆️
src/body_aerodynamics.jl 87.00% <80.00%> (-2.03%) ⬇️
src/wing_geometry.jl 77.59% <77.77%> (-0.47%) ⬇️
src/panel.jl 64.37% <68.49%> (+2.30%) ⬆️

@1-Bart-1 1-Bart-1 marked this pull request as ready for review February 28, 2025 16:11
@1-Bart-1 1-Bart-1 changed the title Dynamically update segments init! functions Feb 28, 2025
@ufechner7 ufechner7 self-requested a review February 28, 2025 16:22
ufechner7
ufechner7 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one inline question

@1-Bart-1 1-Bart-1 merged commit c693757 into main Feb 28, 2025
6 of 7 checks passed
@ufechner7 ufechner7 deleted the feat/dynamic branch March 8, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ufechner7 ufechner7 ufechner7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1-Bart-1 @ufechner7