Skip to content

Add enums AeroModel and InitialGammaDistribution #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1-Bart-1 merged 7 commits into from
Feb 27, 2025
Merged

Add enums AeroModel and InitialGammaDistribution #74

1-Bart-1 merged 7 commits into from
Feb 27, 2025

Conversation

@ufechner7
Copy link
Member

@ufechner7 ufechner7 commented Feb 26, 2025 •
edited
Loading

  • also improve doc strings
  • add page Private Types to docu

@codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/wing_geometry.jl 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/VortexStepMethod.jl 33.33% <ø> (ø)
src/kite_geometry.jl 88.00% <100.00%> (ø)
src/panel.jl 62.06% <100.00%> (ø)
src/solver.jl 76.98% <ø> (-0.80%) ⬇️
src/wing_geometry.jl 78.06% <88.88%> (ø)

... and 1 file with indirect coverage changes

@ufechner7 ufechner7 marked this pull request as ready for review February 27, 2025 12:42
@ufechner7 ufechner7 requested a review from 1-Bart-1 February 27, 2025 12:43
@ufechner7 ufechner7 changed the title Add enum AeroModel Add enums AeroModel and InitialGammaDistribution Feb 27, 2025
1-Bart-1
1-Bart-1 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@1-Bart-1 1-Bart-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@1-Bart-1 1-Bart-1 merged commit 4c6f734 into main Feb 27, 2025
7 checks passed
@1-Bart-1 1-Bart-1 deleted the enum3 branch February 27, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1-Bart-1 1-Bart-1 1-Bart-1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ufechner7 @1-Bart-1