add bento, fix a few bugs it found

Author: jlev

.bento.yml

@@ -0,0 +1,114 @@
+formatter:
+- clippy: {}
+- histo: {}
+tools:
+  r2c.bandit:
+    ignore:
+    - B101
+    - B104
+    - B105
+    - B106
+    - B107
+    - B108
+    - B112
+    - B303
+    - B310
+    - B311
+    - B403
+    - B404
+    - B405
+    - B406
+    - B407
+    - B408
+    - B409
+    - B410
+    - B603
+    - B604
+    - B606
+    - B607
+    - B608
+  r2c.flake8:
+    ignore:
+    - A003
+    - E117
+    - E127
+    - E122
+    - E252
+    - E123
+    - F401
+    - E224
+    - E742
+    - E115
+    - E131
+    - E743
+    - E116
+    - E266
+    - E231
+    - E201
+    - E713
+    - E401
+    - E221
+    - E731
+    - E121
+    - E502
+    - E305
+    - B010
+    - E275
+    - E222
+    - E301
+    - E251
+    - E402
+    - E303
+    - B001
+    - W391
+    - E712
+    - F406
+    - E261
+    - E228
+    - E223
+    - E133
+    - E242
+    - E304
+    - E302
+    - E227
+    - E128
+    - E704
+    - E211
+    - E274
+    - E225
+    - E702
+    - W291
+    - W504
+    - E703
+    - E226
+    - E241
+    - E111
+    - E202
+    - E129
+    - E306
+    - B009
+    - E101
+    - E501
+    - E714
+    - W293
+    - E265
+    - E114
+    - E741
+    - E125
+    - E126
+    - E262
+    - E721
+    - W191
+    - E203
+    - E701
+    - W503
+    - E273
+    - E711
+    - W292
+    - E124
+    - E271
+    - E272
+  r2c.flask:
+    ignore: []
+  r2c.requests:
+    ignore: []

.bentoignore

@@ -0,0 +1,33 @@
+# Items added to this file will be ignored by bento.
+#
+# This file uses .gitignore syntax:
+#
+# To ignore a file anywhere it occurs in your project, enter a
+# glob pattern here. E.g. "*.min.js".
+#
+# To ignore a directory anywhere it occurs in your project, add
+# a trailing slash to the file name. E.g. "dist/".
+#
+# To ignore a file or directory only relative to the project root,
+# include a slash anywhere except the last character. E.g.
+# "/dist/", or "src/generated".
+#
+# Some parts of .gitignore syntax are not supported, and patterns
+# using this syntax will be dropped from the ignore list:
+# - Explicit "include syntax", e.g. "!kept/".
+# - Multi-character expansion syntax, e.g. "*.py[cod]"
+#
+# To include ignore patterns from another file, start a line
+# with ':include', followed by the path of the file. E.g.
+# ":include path/to/other/ignore/file".
+#
+# To ignore a file with a literal ':' character, escape it with
+# a backslash, e.g. "\:foo".
+
+# Ignore Bento environment files
+.bento/
+
+# Ignore git items
+.gitignore
+.git/
+:include .gitignore

.gitignore

@@ -16,3 +16,6 @@ instance/uploads
 .coverage
 cover
 .coveralls.yml
+
+# Ignore bento tool run paths (this line added by `bento init`)
+.bento/

call_server/api/views.py

@@ -357,7 +357,7 @@ def campaign_target_calls(campaign_id):
                 except AttributeError:
                     current_app.logger.error('unable to adapt target_data for %s: %s' % (target_uid, target_data))
             else:
-                current_app.logger.error('no target_data for %s: %s' % (target_uid, e))
+                current_app.logger.error('no target_data for %s' % target_uid)
 
         if adapted_data:    
             targets[target_uid]['title'] = adapted_data.get('title')

call_server/jinja.py

@@ -82,7 +82,7 @@ def leave_tag(self, tag, ctx):
             return
         for idx, other_tag in enumerate(reversed(ctx.stack)):
             if other_tag == tag:
-                for num in xrange(idx + 1):
+                for num in range(idx + 1):
                     ctx.stack.pop()
             elif not self.breaking_rules.get(other_tag):
                 break

call_server/schedule/models.py

@@ -27,11 +27,11 @@ class ScheduleCall(db.Model):
 
     job_id = db.Column(db.String(36)) # UUID4
 
-    def __init__(self, campaign_id, phone_number, time=utc_now().time()):
+    def __init__(self, campaign_id, phone_number, time):
         self.created_at = utc_now()
         self.campaign_id = campaign_id
         self.phone_number = phone_number
-        self.time_to_call = time
+        self.time_to_call = time or utc_now().time()
 
     def __repr__(self):
         return u'<ScheduleCall for {} to {}>'.format(self.campaign.name, self.phone_number.e164)

call_server/sync/integrations/actionkit_crm.py

@@ -48,7 +48,7 @@ def _match_ak_target_data(self, campaign, target):
         if campaign.country_code.upper() == 'US':
             # look up target in political_data
             data_provider = campaign.get_country_data()
-            target_data = data_provider.cache_get(target_key)
+            target_data = data_provider.cache_get(target.key)
 
             if campaign.campaign_type == 'congress':
                 target_state = target_data.get('state', '')

call_server/user/models.py

@@ -1,4 +1,5 @@
 from datetime import datetime
+import functools
 
 from sqlalchemy_utils.types import phone_number
 from werkzeug import generate_password_hash, check_password_hash
@@ -87,7 +88,7 @@ def search(cls, keywords):
                 User.name.ilike(keyword),
                 User.email.ilike(keyword),
             ))
-        q = reduce(db.and_, criteria)
+        q = functools.reduce(db.and_, criteria)
         return cls.query.filter(q)
 
     @classmethod