Skip to content

Commit fcd0743

Browse files
committed
feat: update validation tests to exclude files that will not validate
1 parent 98f04ca commit fcd0743

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# Script for running automated tests on OSB, see https://github.com/OpenSourceBrain/osb-model-validation
2-
# exclude a few that use new component types and are so not valid against the schema
3-
target: "*.channel.nml"
2+
# - exclude a few that use new component types and are so not valid against the schema
3+
# - exclude new concentration models
4+
target: "ch_CavN.channel.nml; ch_KCaS.channel.nml; ch_Kdrfastngf.channel.nml; ch_KvAngf.channel.nml; ch_KvCaB.channel.nml; ch_Navngf.channel.nml; k*.channel.nml; hin.channel.nml; h_kole.channel.nml; h_migliore.channel.nml; I*channel.nml; i*channel.nml; n*channel.nml; N*channel.nml; p*channel.nml; t*channel.nml"
45
engine: jNeuroML_validate

NeuroML2/channels/ch_CavL.channel.nml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,25 @@
33
<notes> GHK!!!</notes>
44
<ionChannel id="ch_CavL" conductance="10pS" type="ionChannelHH" species="ca">
55
<ConductanceScalingCaDependent type="ch_CavL_scale"/>
6+
67
<gate id="m" type="gateHHrates" instances="2">
78
<forwardRate type="HHExpLinearRate" rate="156.9per_ms" scale="10mV" midpoint="81.5mV"/>
89
<reverseRate type="HHExpRate" rate="0.29per_ms" scale="-10.86mV" midpoint="0mV"/>
9-
</gate>
10+
</gate>
1011

1112
</ionChannel>
1213

1314

1415
<ComponentType name="ch_CavL_scale" extends="baseConductanceScaling">
15-
<Requirement name="caConc" dimension="concentration"/>
1616
<Constant name="CONC_SCALE" dimension="concentration" value="1 mM"/>
1717
<Constant name="ki" dimension="none" value="0.001"/>
18-
18+
<Requirement name="caConc" dimension="concentration"/>
19+
1920
<Dynamics>
2021
<DerivedVariable name="ca_conc" dimension="none" value="caConc / CONC_SCALE"/>
2122
<DerivedVariable name="factor" exposure="factor" dimension="none" value="ki / (ki + ca_conc)"/>
2223
</Dynamics>
2324

2425
</ComponentType>
2526

26-
</neuroml>
27+
</neuroml>

0 commit comments

Comments
 (0)