Merge branch 'master' of github.com:OpenSourceBrain/OSBv2 into develop

Author: filippomc

applications/workspaces/tasks/biomodels-copy/run.sh

@@ -30,7 +30,17 @@ else
         echo "${path}" >> filelist
     done
     echo Biomodels downloading files
-    aria2c --retry-wait=2 --max-tries=5 --input-file=filelist --max-concurrent-downloads=5 --max-connection-per-server=5 --allow-overwrite "true" --auto-file-renaming "false"
+    # Move to temporary directory to rename only the downloaded files.
+    # Otherwise we risk renaming all files, even ones where the user has used
+    # '+' in the file name explicitly
+    tempdir=$(mktemp -d)
+    pushd "${tempdir}"
+        aria2c --retry-wait=2 --max-tries=5 --input-file=filelist --max-concurrent-downloads=5 --max-connection-per-server=5 --allow-overwrite "true" --auto-file-renaming "false"
+        rename -a '+' ' ' *.*
+    popd
+    mv "${tempdir}/*" .
+    # directory should be empty, so rmdir will work
+    rmdir "${tempdir}"
     rm filelist -f
 fi