Skip to content

Commit f13cfbb

Browse files
Merge pull request #144 from OpenSourceBrain/feat-remove-double-error
Feat: remove double error printing
2 parents 14eddb0 + fdd51eb commit f13cfbb

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

omv/common/inout.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -120,29 +120,18 @@ def check_output(cmds, cwd=".", shell=False, verbosity=0, env=None):
120120
return ret_string
121121

122122
except sp.CalledProcessError as err:
123-
inform(
124-
"CalledProcessError running commands: %s in %s (return code: %s), output:\n%s"
125-
% (cmds, cwd, err.returncode, err.output),
126-
indent=2,
127-
verbosity=verbosity,
128-
)
129123
inform("Error: %s" % (err), indent=2, verbosity=verbosity)
130124
raise err
131125
except Exception as err:
132-
inform(
133-
"Error running commands: %s in (%s)!" % (cmds, cwd),
134-
indent=2,
135-
verbosity=verbosity,
136-
)
137126
inform("Error: %s" % (err), indent=2, verbosity=verbosity)
138127
raise err
139128

140129

141130
def pip_install(packages, version=None):
142131
pip = "pip3" if sys.version_info.major == 3 else "pip"
143132
cmds = [pip, "install"]
144-
if type(packages) == str:
145-
if version == None:
133+
if isinstance(packages, str):
134+
if version is None:
146135
cmds.append(packages)
147136
else:
148137
cmds.append("%s==%s" % (packages, version))

0 commit comments

Comments
 (0)