Skip to content

Commit efd30b0

Browse files
committed
Ah, I see why the linux build required 'sudo' (which isn't even installed on debian-slim). It wasn't inside a docker! This 'container' key is what I want
* https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontainer
1 parent 6c50e8a commit efd30b0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ jobs:
1111

1212
linux:
1313
runs-on: ubuntu-latest
14+
container: debian:buster-slim
1415

1516
steps:
16-
- uses: docker://debian:buster-slim
1717
- uses: actions/checkout@v2
1818

1919
- name: Execute script to build linux AppImage

build/linux/buildAppImage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ PYTHON_PATH='/usr/bin/python3.7'
2626
###################
2727

2828
# install os-level depends
29-
sudo apt-get update; sudo apt-get -y install python3.7 python3-pip wget rsync fuse
29+
apt-get update; apt-get -y install python3.7 python3-pip wget rsync fuse
3030

3131
# setup a virtualenv to isolate our app's python depends
3232
${PYTHON_PATH} -m pip install --upgrade --user pip setuptools virtualenv

0 commit comments

Comments
 (0)