Skip to content

Periodical analysis of PR reviewing guidelines #175

@SAUMILDHANKAR

Description

@SAUMILDHANKAR

Description

We need to discuss and document guidelines for PR review. The idea is to optimize PR review process with team feedback. So we will vote on things we want as a team.


Things to vote on

  • Agree on PR review timing (PM review after 1–2 weeks as last resort?).
  • Minimum one review ok or two
  • Reconfirm squash and merge as the default strategy.
  • Is low quality PM review better than no review.
  • Automatic reviewer assignment?
  • PR template (include images if possible, any other)

Acceptance Criteria

  • Guidelines and voting documented in comments and some things can go on wiki

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions