[FEATURE] adds meaningful error handling refs #165

Author: Markus Falk

addcomponent/index.js

@@ -21,16 +21,13 @@ lineNumber = require('line-number'),
 AddcomponentGenerator = yeoman.generators.NamedBase.extend({
 
   /**
-   * Loads package.json and waits for callback to finish. Also tells user what happened and gives a little help.
+   * Loads package.json and binds events.
    * @function init
    * @private
    */
   init: function () {
 
-    this.pkg = this.fs.readJSON('package.json');
-
     this.on('end', function () {
-
       // output a little help
       if (this.ComponentType === 'standardModule') {
         if(this.includeHTML) {
@@ -41,8 +38,23 @@ AddcomponentGenerator = yeoman.generators.NamedBase.extend({
           this.log('You can use it in your HTML with ' + chalk.yellow('{deferred:{' + string.slugify(this.name) + '}}'));
         }
       }
+    });
 
+    // take care of error handling
+    this.on('error', function(message) {
+      // print error message
+      this.log.error(message);
+      // exit shell
+      process.exit(5);
     });
+
+    // load package.json
+    try {
+      this.pkg = this._loadJSON('package.json');
+    } catch (error) {
+      this.emit('error', error);
+      return;
+    }
   },
 
   /**
@@ -55,6 +67,23 @@ AddcomponentGenerator = yeoman.generators.NamedBase.extend({
     return this.features && this.features.indexOf(feature) !== -1;
   },
 
+  /**
+   * Loads JSON files.
+   * @function _loadJSON
+   * @returns {JSON} file's contents
+   * @private
+   */
+  _loadJSON: function(name) {
+    var json = this.fs.readJSON(name);
+
+    if(json) {
+      return json;
+    } else {
+      throw new Error('Could not open ' + name + '. Are you in root directory of the project?');
+    }
+
+  },
+
   /**
    * Asks user questions about the component.
    * @function askForApp
@@ -208,6 +237,7 @@ AddcomponentGenerator = yeoman.generators.NamedBase.extend({
    * @private
    */
   addStyling: function () {
+
     if (this.includeSCSS) {
 
       var
@@ -220,6 +250,12 @@ AddcomponentGenerator = yeoman.generators.NamedBase.extend({
         path = 'components/_' + this.pkg.name + '.scss';
       }
 
+      this.log('PATH: ' + path);
+
+      if(!this.fs.exists(path)) {
+        this.log.error('FILE DOESNT EXIST');
+      }
+
       // read
       var
       file = this.fs.read(path),

removecomponent/index.js

@@ -21,7 +21,6 @@ RemovecomponentGenerator = yeoman.generators.NamedBase.extend({
    * @private
    */
   constructor: function () {
-    // console.log(yeoman.NamedBase);
     yeoman.Base.apply(this, arguments);
 
     this.argument('name', {
@@ -30,6 +29,31 @@ RemovecomponentGenerator = yeoman.generators.NamedBase.extend({
       desc: 'The component name.'
     });
 
+    // take care of error handling
+    this.on('error', function(message) {
+      // print error message
+      this.log.error(message);
+      // exit shell
+      process.exit(5);
+    });
+
+  },
+
+  /**
+   * Loads JSON files.
+   * @function _loadJSON
+   * @returns {JSON} file's contents
+   * @private
+   */
+  _loadJSON: function(name) {
+    var json = this.fs.readJSON(name);
+
+    if(json) {
+      return json;
+    } else {
+      throw new Error('Could not open ' + name + '. Are you in root directory of the project?');
+    }
+
   },
 
   /**
@@ -38,7 +62,12 @@ RemovecomponentGenerator = yeoman.generators.NamedBase.extend({
    * @private
    */
   getPackage: function () {
-    this.pkg = this.fs.readJSON('package.json');
+    try {
+      this.pkg = this._loadJSON('package.json');
+    } catch (error) {
+      this.emit('error', error);
+      return;
+    }
   },
 
   /**