Fix Color.foregroundStyle recursive loop (#730)

Kyle-Ye · web-flow · commit a198635922de · 2026-01-18T17:34:14.000+08:00
diff --git a/Sources/OpenSwiftUICore/Shape/ShapeStyle/ForegroundStyle.swift b/Sources/OpenSwiftUICore/Shape/ShapeStyle/ForegroundStyle.swift
@@ -88,6 +88,7 @@ extension ForegroundStyle {
         if shape.activeRecursiveStyles.contains(.foreground) {
             LegacyContentStyle.sharedPrimary._apply(to: &shape)
         } else {
+            shape.activeRecursiveStyles.formUnion(.foreground)
             shape.effectiveForegroundStyle._apply(to: &shape)
             shape.activeRecursiveStyles.subtract(.foreground)
         }
diff --git a/Sources/OpenSwiftUICore/Shape/ShapeStyle/ShapeStyleShape.swift b/Sources/OpenSwiftUICore/Shape/ShapeStyle/ShapeStyleShape.swift
@@ -104,7 +104,7 @@ public struct _ShapeStyle_Shape {
     }
     
     package var effectiveForegroundStyle: AnyShapeStyle {
-        environment._effectiveForegroundStyle
+        foregroundStyle ?? environment._effectiveForegroundStyle
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ extension ForegroundStyle {`
`88`	`88`	`if shape.activeRecursiveStyles.contains(.foreground) {`
`89`	`89`	`LegacyContentStyle.sharedPrimary._apply(to: &shape)`
`90`	`90`	`} else {`
	`91`	`+ shape.activeRecursiveStyles.formUnion(.foreground)`
`91`	`92`	`shape.effectiveForegroundStyle._apply(to: &shape)`
`92`	`93`	`shape.activeRecursiveStyles.subtract(.foreground)`
`93`	`94`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ public struct _ShapeStyle_Shape {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`package var effectiveForegroundStyle: AnyShapeStyle {`
`107`		`- environment._effectiveForegroundStyle`
	`107`	`+ foregroundStyle ?? environment._effectiveForegroundStyle`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`