Skip to content

Commit dcf4c9a

Browse files
committed
Update OpenGraph dependency
1 parent b4addfb commit dcf4c9a

File tree

7 files changed

+51
-21
lines changed

7 files changed

+51
-21
lines changed

.github/workflows/compatibility_tests.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ jobs:
2222
OPENSWIFTUI_SWIFT_LOG: 0
2323
OPENSWIFTUI_SWIFT_CRYPTO: 0
2424
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
25+
OPENSWIFTUI_USE_LOCAL_DEPS: 1
26+
OPENGRAPH_USE_LOCAL_DEPS: 1
27+
OPENGRAPH_TARGET_RELEASE: ${{ matrix.release }}
28+
DARWIN_PRIVATE_FRAMEWORKS_TARGET_RELEASE: ${{ matrix.release }}
29+
GH_TOKEN: ${{ github.token }}
2530
steps:
2631
- uses: actions/checkout@v4
2732
- name: Setup Xcode
@@ -64,6 +69,11 @@ jobs:
6469
OPENSWIFTUI_SWIFT_CRYPTO: 0
6570
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
6671
OPENSWIFTUI_SUPPORT_MULTI_PRODUCTS: 0
72+
OPENSWIFTUI_USE_LOCAL_DEPS: 1
73+
OPENGRAPH_USE_LOCAL_DEPS: 1
74+
OPENGRAPH_TARGET_RELEASE: ${{ matrix.release }}
75+
DARWIN_PRIVATE_FRAMEWORKS_TARGET_RELEASE: ${{ matrix.release }}
76+
GH_TOKEN: ${{ github.token }}
6777
steps:
6878
- uses: actions/checkout@v4
6979
- name: Setup Xcode

.github/workflows/ios.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ jobs:
2727
OPENSWIFTUI_SWIFT_LOG: 0
2828
OPENSWIFTUI_SWIFT_CRYPTO: 0
2929
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
30-
OPENSWIFTUI_USE_LOCAL_DEPS: 1
3130
OPENSWIFTUI_SUPPORT_MULTI_PRODUCTS: 0
31+
OPENSWIFTUI_USE_LOCAL_DEPS: 1
32+
OPENGRAPH_USE_LOCAL_DEPS: 1
3233
OPENGRAPH_TARGET_RELEASE: ${{ matrix.release }}
33-
OPENGRAPH_ATTRIBUTEGRAPH_VERSION: RELEASE_${{ matrix.release }}
34+
DARWIN_PRIVATE_FRAMEWORKS_TARGET_RELEASE: ${{ matrix.release }}
3435
GH_TOKEN: ${{ github.token }}
3536
steps:
3637
- uses: actions/checkout@v4
@@ -41,7 +42,7 @@ jobs:
4142
- name: Swift version
4243
run: swift --version
4344
- name: Set up build environment
44-
run: Scripts/CI/macOS_setup_build.sh
45+
run: Scripts/CI/darwin_setup_build.sh
4546
shell: bash
4647
- name: Build test target in debug mode
4748
run: |

.github/workflows/macos.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ jobs:
2424
OPENSWIFTUI_SWIFT_CRYPTO: 0
2525
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
2626
OPENSWIFTUI_USE_LOCAL_DEPS: 1
27+
OPENGRAPH_USE_LOCAL_DEPS: 1
2728
OPENGRAPH_TARGET_RELEASE: ${{ matrix.release }}
28-
OPENGRAPH_ATTRIBUTEGRAPH_VERSION: RELEASE_${{ matrix.release }}
29+
DARWIN_PRIVATE_FRAMEWORKS_TARGET_RELEASE: ${{ matrix.release }}
2930
GH_TOKEN: ${{ github.token }}
3031
steps:
3132
- uses: actions/checkout@v4
@@ -36,7 +37,7 @@ jobs:
3637
- name: Swift version
3738
run: swift --version
3839
- name: Set up build environment
39-
run: Scripts/CI/macOS_setup_build.sh
40+
run: Scripts/CI/darwin_setup_build.sh
4041
shell: bash
4142
- name: Build and run tests in debug mode with coverage
4243
run: |

Package.resolved

Lines changed: 11 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ extension Target {
241241
func addAGSettings() {
242242
// FIXME: Weird SwiftPM behavior for test Target. Otherwize we'll get the following error message
243243
// "could not determine executable path for bundle 'AttributeGraph.framework'"
244-
dependencies.append(.product(name: "AttributeGraph", package: "OpenGraph"))
244+
dependencies.append(.product(name: "AttributeGraph", package: "DarwinPrivateFrameworks"))
245245
var swiftSettings = swiftSettings ?? []
246246
swiftSettings.append(.define("OPENGRAPH_ATTRIBUTEGRAPH"))
247247
self.swiftSettings = swiftSettings
@@ -269,7 +269,17 @@ extension Target {
269269
}
270270
}
271271

272+
let useLocalDeps = envEnable("OPENSWIFTUI_USE_LOCAL_DEPS")
273+
272274
if attributeGraphCondition {
275+
let privateFrameworkRepo: Package.Dependency
276+
if useLocalDeps {
277+
privateFrameworkRepo = Package.Dependency.package(path: "../DarwinPrivateFrameworks")
278+
} else {
279+
privateFrameworkRepo = Package.Dependency.package(url: "https://github.com/OpenSwiftUIProject/DarwinPrivateFrameworks.git", branch: "main")
280+
}
281+
package.dependencies.append(privateFrameworkRepo)
282+
273283
openSwiftUICoreTarget.addAGSettings()
274284
openSwiftUITarget.addAGSettings()
275285

@@ -280,6 +290,17 @@ if attributeGraphCondition {
280290
openSwiftUIBridgeTestTarget.addAGSettings()
281291
}
282292

293+
if useLocalDeps {
294+
package.dependencies += [
295+
.package(path: "../OpenGraph"),
296+
]
297+
} else {
298+
package.dependencies += [
299+
// FIXME: on Linux platform: OG contains unsafe build flags which prevents us using version dependency
300+
.package(url: "https://github.com/OpenSwiftUIProject/OpenGraph", branch: "main"),
301+
]
302+
}
303+
283304
#if os(macOS)
284305
let openCombineCondition = envEnable("OPENSWIFTUI_OPENCOMBINE")
285306
#else
@@ -328,18 +349,6 @@ if compatibilityTestCondition {
328349
openSwiftUICompatibilityTestTarget.dependencies.append("OpenSwiftUI")
329350
}
330351

331-
let useLocalDeps = envEnable("OPENSWIFTUI_USE_LOCAL_DEPS")
332-
if useLocalDeps {
333-
package.dependencies += [
334-
.package(path: "../OpenGraph"),
335-
]
336-
} else {
337-
package.dependencies += [
338-
// FIXME: on Linux platform: OG contains unsafe build flags which prevents us using version dependency
339-
.package(url: "https://github.com/OpenSwiftUIProject/OpenGraph", branch: "main"),
340-
]
341-
}
342-
343352
extension [Platform] {
344353
static var nonDarwinPlatforms: [Platform] {
345354
[.linux, .android, .wasi, .openbsd, .windows]

Scripts/CI/og_setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ clone_checkout_og() {
1818

1919
update_og() {
2020
cd $REPO_ROOT/../OpenGraph
21-
./AG/update.sh
21+
./Scripts/CI/darwin_setup_build.sh
2222
}
2323

2424
clone_checkout_og

0 commit comments

Comments
 (0)