Skip to content

Optimize overflow for StackLayout.makeChildren() #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pookjw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize overflow for StackLayout.makeChildren() #715

pookjw wants to merge 1 commit into from

Conversation

@pookjw
Copy link
Member

@pookjw pookjw commented Jan 9, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 9, 2026

🤖 Augment PR Summary

Summary: Optimizes StackLayout.makeChildren() spacing calculation by using wrapping subtraction (&-) when indexing the previous subview.
Why: Avoids overflow-check overhead in the non-zero index path while keeping behavior consistent due to the existing index == 0 guard.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Jan 9, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pookjw