From 1fd0475ebb26e2c573010bb2570b2b6b02355b65 Mon Sep 17 00:00:00 2001 From: Hari Shreedharan Date: Thu, 27 Jul 2017 13:16:53 -0700 Subject: [PATCH] Deferred should not be final We use the Async Kudu Client (and I have used the Async HBase client before), and we have issues testing this in unit tests because the Deferred class is final. To mock it, we have to jump through hoops with power mock. I don't see a reason for this class to be final, so just removing the final keyword. --- src/Deferred.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Deferred.java b/src/Deferred.java index 19669a2..e89b0b3 100644 --- a/src/Deferred.java +++ b/src/Deferred.java @@ -424,7 +424,7 @@ * * @param The type of the deferred result. */ -public final class Deferred { +public class Deferred { // I apologize in advance for all the @SuppressWarnings("unchecked") in this // class. I feel like I'm cheating the type system but, to be honest, Java's