Skip to content

Commit a47781e

Browse files
committed
Setting version to 2.5.0-RC1
1 parent 7ab8b34 commit a47781e

File tree

6 files changed

+23
-63
lines changed

6 files changed

+23
-63
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,4 @@ tools/docker/opentsdb.conf
5050
fat-jar-pom.xml
5151
src-resources/
5252
test-resources/
53+
third_party/*/*.jar

configure.ac

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
# along with this library. If not, see <http://www.gnu.org/licenses/>.
1515

1616
# Semantic Versioning (see http://semver.org/).
17-
AC_INIT([opentsdb], [2.5.0-SNAPSHOT], [[email protected]])
17+
AC_INIT([opentsdb], [2.5.0-RC1], [[email protected]])
1818
AC_CONFIG_AUX_DIR([build-aux])
1919
AM_INIT_AUTOMAKE([foreign])
2020

pom.xml.in

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@
7070
<artifactId>maven-compiler-plugin</artifactId>
7171
<version>2.5.1</version>
7272
<configuration>
73-
<source>1.6</source>
74-
<target>1.6</target>
73+
<source>1.8</source>
74+
<target>1.8</target>
7575
<compilerArgument>-Xlint</compilerArgument>
7676
<excludes>
7777
<exclude>**/client/*.java</exclude>
@@ -326,7 +326,7 @@
326326
<goal>javacc</goal>
327327
</goals>
328328
<configuration>
329-
<jdkVersion>1.6</jdkVersion>
329+
<jdkVersion>1.8</jdkVersion>
330330
<javadocFriendlyComments>true</javadocFriendlyComments>
331331
<packageName>net.opentsdb.query.expression.parser</packageName>
332332
<sourceDirectory>${basedir}/src/</sourceDirectory>

src/core/SaltScanner.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -960,7 +960,6 @@ private void validateAndTriggerCallback(
960960
histMap.put(scannersRunning, histograms);
961961
}
962962

963-
int scannersRunning = countdown.decrementAndGet();
964963
if (scannersRunning <= 0) {
965964
try {
966965
mergeAndReturnResults();

src/core/SplitRollupSpanGroup.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ public Map<String, String> call(ArrayList<Map<String, String>> resolvedTags) thr
119119
*/
120120
@Override
121121
public Bytes.ByteMap<byte[]> getTagUids() {
122+
Bytes.ByteMap<byte[]> tagUids = new Bytes.ByteMap<byte[]>();
122123

123124
for (SpanGroup group : spanGroups) {
124125
tagUids.putAll(group.getTagUids());

src/query/QueryUtil.java

Lines changed: 17 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -418,39 +418,39 @@ public static void setDataTableScanFilter(
418418
final boolean explicit_tags,
419419
final boolean enable_fuzzy_filter,
420420
final int end_time) {
421-
421+
422422
// no-op
423-
if ((group_bys == null || group_bys.isEmpty())
424-
&& (row_key_literals == null || row_key_literals.isEmpty())) {
423+
if ((group_bys == null || group_bys.isEmpty())
424+
&& (row_key_literals == null || row_key_literals.isEmpty())) {
425425
return;
426426
}
427-
427+
428428
if (group_bys != null) {
429429
Collections.sort(group_bys, Bytes.MEMCMP);
430430
}
431431

432432
final int prefix_width = Const.SALT_WIDTH() + TSDB.metrics_width() +
433-
Const.TIMESTAMP_BYTES;
433+
Const.TIMESTAMP_BYTES;
434434

435435
final FuzzyRowFilter fuzzy_filter;
436436
if (explicit_tags &&
437-
enable_fuzzy_filter &&
438-
row_key_literals != null &&
439-
!row_key_literals.isEmpty()) {
437+
enable_fuzzy_filter &&
438+
row_key_literals != null &&
439+
!row_key_literals.isEmpty()) {
440440

441441
final byte[] fuzzy_key = new byte[prefix_width + (row_key_literals.size() *
442-
(TSDB.tagk_width() + TSDB.tagv_width()))];
442+
(TSDB.tagk_width() + TSDB.tagv_width()))];
443443
System.arraycopy(scanner.getCurrentKey(), 0, fuzzy_key, 0,
444-
scanner.getCurrentKey().length);
444+
scanner.getCurrentKey().length);
445445

446446
final List<FuzzyFilterPair> fuzzy_filter_pairs =
447-
buildFuzzyFilters(row_key_literals, fuzzy_key);
447+
buildFuzzyFilters(row_key_literals, fuzzy_key);
448448

449449
// The Fuzzy Filter list is sorted: the first and last filters row key
450450
// can be used to build the stop key for the scanner
451451
final byte[] stop_key = Arrays.copyOf(
452-
fuzzy_filter_pairs.get(fuzzy_filter_pairs.size() - 1).getRowKey(),
453-
fuzzy_key.length);
452+
fuzzy_filter_pairs.get(fuzzy_filter_pairs.size() - 1).getRowKey(),
453+
fuzzy_key.length);
454454
System.arraycopy(scanner.getCurrentKey(), 0, stop_key, 0, prefix_width);
455455
Internal.setBaseTime(stop_key, end_time);
456456
int idx = prefix_width + TSDB.tagk_width();
@@ -474,66 +474,25 @@ public static void setDataTableScanFilter(
474474
if (!Strings.isNullOrEmpty(regex)) {
475475
if (LOG.isDebugEnabled()) {
476476
LOG.debug("Regex for scanner: " + scanner + ": " +
477-
byteRegexToString(regex));
477+
byteRegexToString(regex));
478478
}
479479
regex_filter = new KeyRegexpFilter(regex.toString(),
480-
Const.ASCII_CHARSET);
480+
Const.ASCII_CHARSET);
481481
} else {
482482
regex_filter = null;
483483
}
484484

485485
if (fuzzy_filter != null && !Strings.isNullOrEmpty(regex)) {
486486
final FilterList filter = new FilterList(Lists.newArrayList(fuzzy_filter,
487-
regex_filter),Operator.MUST_PASS_ALL);
487+
regex_filter), Operator.MUST_PASS_ALL);
488488
scanner.setFilter(filter);
489489
} else if (fuzzy_filter != null) {
490490
scanner.setFilter(fuzzy_filter);
491491
} else if (!Strings.isNullOrEmpty(regex)) {
492492
scanner.setFilter(regex_filter);
493493
}
494-
495-
if (explicit_tags && enable_fuzzy_filter) {
496-
final List<FuzzyFilterPair> fuzzy_filter_pairs =
497-
buildFuzzyFilters(row_key_literals);
498-
499-
// The Fuzzy Filter list is sorted: the first and last filters row key
500-
// can be used to build a start and stop keys for the scanner
501-
final byte[] start_key = Arrays.copyOf(
502-
fuzzy_filter_pairs.get(0).getRowKey(),
503-
fuzzy_filter_pairs.get(0).getRowKey().length);
504-
System.arraycopy(scanner.getCurrentKey(), 0, start_key, 0, prefix_width);
505-
506-
final byte[] stop_key = Arrays.copyOf(
507-
fuzzy_filter_pairs.get(fuzzy_filter_pairs.size()-1).getRowKey(),
508-
start_key.length);
509-
System.arraycopy(scanner.getCurrentKey(), 0,
510-
stop_key, 0, prefix_width);
511-
Internal.setBaseTime(stop_key, end_time);
512-
int idx = prefix_width + TSDB.tagk_width();
513-
// max out the tag values
514-
while (idx < stop_key.length) {
515-
for (int i = 0; i < TSDB.tagv_width(); i++) {
516-
stop_key[idx++] = (byte) 0xFF;
517-
}
518-
idx += TSDB.tagk_width();
519-
}
520-
521-
scanner.setStartKey(start_key);
522-
scanner.setStopKey(stop_key);
523-
scanner.setFilter(new FuzzyRowFilter(fuzzy_filter_pairs));
524-
} else {
525-
final String regex = getRowKeyUIDRegex(row_key_literals, explicit_tags);
526-
final KeyRegexpFilter regex_filter = new KeyRegexpFilter(
527-
regex.toString(), Const.ASCII_CHARSET);
528-
if (LOG.isDebugEnabled()) {
529-
LOG.debug("Regex for scanner: " + scanner + ": " +
530-
byteRegexToString(regex));
531-
}
532-
533-
scanner.setFilter(regex_filter);
534-
}
535494
}
536-
495+
537496
/**
538497
* Creates a regular expression with a list of or'd TUIDs to compare
539498
* against the rows in storage.

0 commit comments

Comments
 (0)