Improve deployment documentation #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-terms-archive-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ndpnt
reviewed
Oct 16, 2024
| #### Create the SSH key | ||
|
|
||
| - Create a new SSH key: `ssh-keygen -t ed25519 -C [email protected] -P "" -f ./<collection_name>-key` | ||
| - Create a new SSH key: `ssh-keygen -t ed25519 -C [email protected] -P "" -f ~/.ssh/<collection_name>-key` |
There was a problem hiding this comment.
Why creating this key in your ssh folder whereas it should be deleted from your computer after backing it up and attached to the OTA-Bot user?
Ndpnt
reviewed
Oct 16, 2024
|
|
||
| ```shell | ||
| <user> ALL=(ALL) NOPASSWD:ALL | ||
| <username> ALL=(ALL:ALL) NOPASSWD:ALL |
There was a problem hiding this comment.
Why do you need to allow the user to specify both the target user and group when using sudo?
|
@clementbiron is this PR still relevant? |
|
As this is a PR that has been open for too long and I'm no longer sure of its validity, I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes minor improvements to deployment documentation.