Skip to content

Commit 51d710e

Browse files
NdpntNdpnt
committed
Make atomic functions pure, removing logging
1 parent 4f06fe5 commit 51d710e

File tree

1 file changed

+47
-91
lines changed

1 file changed

+47
-91
lines changed

‎src/reporter/github.js‎

Lines changed: 47 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -51,119 +51,75 @@ export default class GitHub {
5151
}
5252

5353
async getRepositoryLabels() {
54-
try {
55-
const { data: labels } = await this.octokit.request('GET /repos/{owner}/{repo}/labels', { ...this.commonParams });
54+
const { data: labels } = await this.octokit.request('GET /repos/{owner}/{repo}/labels', { ...this.commonParams });
5655

57-
return labels;
58-
} catch (error) {
59-
logger.error(`🤖 Could not get labels: ${error}`);
60-
}
56+
return labels;
6157
}
6258

6359
async createLabel({ name, color, description }) {
64-
try {
65-
await this.octokit.request('POST /repos/{owner}/{repo}/labels', {
66-
...this.commonParams,
67-
name,
68-
color,
69-
description,
70-
});
71-
72-
logger.info(`🤖 Created repository label "${name}"`);
73-
} catch (error) {
74-
logger.error(`🤖 Could not create label "${name}": ${error}`);
75-
}
60+
await this.octokit.request('POST /repos/{owner}/{repo}/labels', {
61+
...this.commonParams,
62+
name,
63+
color,
64+
description,
65+
});
7666
}
7767

7868
async createIssue({ title, description: body, labels }) {
79-
try {
80-
const { data: issue } = await this.octokit.request('POST /repos/{owner}/{repo}/issues', {
81-
...this.commonParams,
82-
title,
83-
body,
84-
labels,
85-
});
86-
87-
logger.info(`🤖 Created GitHub issue #${issue.number} "${title}": ${issue.html_url}`);
88-
89-
return issue;
90-
} catch (error) {
91-
logger.error(`🤖 Could not create GitHub issue "${title}": ${error}`);
92-
}
69+
const { data: issue } = await this.octokit.request('POST /repos/{owner}/{repo}/issues', {
70+
...this.commonParams,
71+
title,
72+
body,
73+
labels,
74+
});
75+
76+
return issue;
9377
}
9478

9579
async setIssueLabels({ issue, labels }) {
96-
try {
97-
await this.octokit.request('PUT /repos/{owner}/{repo}/issues/{issue_number}/labels', {
98-
...this.commonParams,
99-
issue_number: issue.number,
100-
labels,
101-
});
102-
103-
logger.info(`🤖 Updated labels to GitHub issue #${issue.number}`);
104-
} catch (error) {
105-
logger.error(`🤖 Could not update GitHub issue #${issue.number} "${issue.title}": ${error}`);
106-
}
80+
await this.octokit.request('PUT /repos/{owner}/{repo}/issues/{issue_number}/labels', {
81+
...this.commonParams,
82+
issue_number: issue.number,
83+
labels,
84+
});
10785
}
10886

10987
async openIssue(issue) {
110-
try {
111-
await this.octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', {
112-
...this.commonParams,
113-
issue_number: issue.number,
114-
state: GitHub.ISSUE_STATE_OPEN,
115-
});
116-
117-
logger.info(`🤖 Opened GitHub issue #${issue.number}`);
118-
} catch (error) {
119-
logger.error(`🤖 Could not update GitHub issue #${issue.number} "${issue.title}": ${error}`);
120-
}
88+
await this.octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', {
89+
...this.commonParams,
90+
issue_number: issue.number,
91+
state: GitHub.ISSUE_STATE_OPEN,
92+
});
12193
}
12294

12395
async closeIssue(issue) {
124-
try {
125-
await this.octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', {
126-
...this.commonParams,
127-
issue_number: issue.number,
128-
state: GitHub.ISSUE_STATE_CLOSED,
129-
});
130-
131-
logger.info(`🤖 Closed GitHub issue #${issue.number}`);
132-
} catch (error) {
133-
logger.error(`🤖 Could not update GitHub issue #${issue.number} "${issue.title}": ${error}`);
134-
}
96+
await this.octokit.request('PATCH /repos/{owner}/{repo}/issues/{issue_number}', {
97+
...this.commonParams,
98+
issue_number: issue.number,
99+
state: GitHub.ISSUE_STATE_CLOSED,
100+
});
135101
}
136102

137103
async getIssue({ title, ...searchParams }) {
138-
try {
139-
const issues = await this.octokit.paginate('GET /repos/{owner}/{repo}/issues', {
140-
...this.commonParams,
141-
per_page: 100,
142-
...searchParams,
143-
}, response => response.data);
144-
145-
const [issue] = issues.filter(item => item.title === title); // since only one is expected, use the first one
146-
147-
return issue;
148-
} catch (error) {
149-
logger.error(`🤖 Could not find GitHub issue "${title}": ${error}`);
150-
}
104+
const issues = await this.octokit.paginate('GET /repos/{owner}/{repo}/issues', {
105+
...this.commonParams,
106+
per_page: 100,
107+
...searchParams,
108+
}, response => response.data);
109+
110+
const [issue] = issues.filter(item => item.title === title); // since only one is expected, use the first one
111+
112+
return issue;
151113
}
152114

153115
async addCommentToIssue({ issue, comment: body }) {
154-
try {
155-
const { data: comment } = await this.octokit.request('POST /repos/{owner}/{repo}/issues/{issue_number}/comments', {
156-
...this.commonParams,
157-
issue_number: issue.number,
158-
body,
159-
});
160-
161-
logger.info(`🤖 Added comment to GitHub issue #${issue.number}: ${comment.html_url}`);
162-
163-
return comment;
164-
} catch (error) {
165-
logger.error(`🤖 Could not add comment to GitHub issue #${issue.number} "${issue.title}": ${error}`);
166-
}
116+
const { data: comment } = await this.octokit.request('POST /repos/{owner}/{repo}/issues/{issue_number}/comments', {
117+
...this.commonParams,
118+
issue_number: issue.number,
119+
body,
120+
});
121+
122+
return comment;
167123
}
168124

169125
async closeIssueWithCommentIfExists({ title, comment }) {

0 commit comments

Comments
 (0)