Add tests for schemas

Ndpnt · Ndpnt · commit afb406ff524d · 2025-09-16T16:04:49.000+02:00
diff --git a/scripts/declarations/validate/fixtures/invalid-history/invalid-date.json b/scripts/declarations/validate/fixtures/invalid-history/invalid-date.json
@@ -0,0 +1,9 @@
+{
+  "Privacy Policy": [
+    {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content",
+      "validUntil": "2023-12-31"
+    }
+  ]
+}
diff --git a/scripts/declarations/validate/fixtures/invalid-history/missing-valid-until.json b/scripts/declarations/validate/fixtures/invalid-history/missing-valid-until.json
@@ -0,0 +1,8 @@
+{
+  "Privacy Policy": [
+    {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content"
+    }
+  ]
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/additional-properties.json b/scripts/declarations/validate/fixtures/invalid/additional-properties.json
@@ -0,0 +1,10 @@
+{
+  "name": "Service with additional properties",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content"
+    }
+  },
+  "unexpectedProperty": "value"
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/invalid-filter-object.json b/scripts/declarations/validate/fixtures/invalid/invalid-filter-object.json
@@ -0,0 +1,17 @@
+{
+  "name": "Service with invalid filter object",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content",
+      "filter": [
+        {
+          "filterName": {
+            "param": "value"
+          },
+          "unexpectedAdditionalProperty": "value"
+        }
+      ]
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/invalid-terms-type.json b/scripts/declarations/validate/fixtures/invalid/invalid-terms-type.json
@@ -0,0 +1,9 @@
+{
+  "name": "Service with invalid terms type",
+  "terms": {
+    "Invalid Terms Type": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/invalid-url.json b/scripts/declarations/validate/fixtures/invalid/invalid-url.json
@@ -0,0 +1,9 @@
+{
+  "name": "Service with invalid URL",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "not-a-valid-url",
+      "select": "div.content"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/missing-fetch.json b/scripts/declarations/validate/fixtures/invalid/missing-fetch.json
@@ -0,0 +1,8 @@
+{
+  "name": "Service without fetch",
+  "terms": {
+    "Privacy Policy": {
+      "select": "div.content"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/missing-name.json b/scripts/declarations/validate/fixtures/invalid/missing-name.json
@@ -0,0 +1,8 @@
+{
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/missing-select.json b/scripts/declarations/validate/fixtures/invalid/missing-select.json
@@ -0,0 +1,8 @@
+{
+  "name": "Service without select",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/missing-terms.json b/scripts/declarations/validate/fixtures/invalid/missing-terms.json
@@ -0,0 +1,3 @@
+{
+  "name": "Service without terms"
+}
diff --git a/scripts/declarations/validate/fixtures/invalid/non-pdf-url-for-pdf.json b/scripts/declarations/validate/fixtures/invalid/non-pdf-url-for-pdf.json
@@ -0,0 +1,8 @@
+{
+  "name": "Service with non-PDF URL for PDF document",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy.html"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid-history/pdf-history.json b/scripts/declarations/validate/fixtures/valid-history/pdf-history.json
@@ -0,0 +1,8 @@
+{
+  "Privacy Policy": [
+    {
+      "fetch": "https://example.com/privacy.pdf",
+      "validUntil": "2023-12-31T23:59:59Z"
+    }
+  ]
+}
diff --git a/scripts/declarations/validate/fixtures/valid-history/simple-history.json b/scripts/declarations/validate/fixtures/valid-history/simple-history.json
@@ -0,0 +1,9 @@
+{
+  "Privacy Policy": [
+    {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content",
+      "validUntil": "2023-12-31T23:59:59Z"
+    }
+  ]
+}
diff --git a/scripts/declarations/validate/fixtures/valid/complex-service.json b/scripts/declarations/validate/fixtures/valid/complex-service.json
@@ -0,0 +1,30 @@
+{
+  "name": "Complex service",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": [
+        "div.content",
+        ".privacy-section"
+      ],
+      "filter": [
+        "removeLinks",
+        {
+          "customTransform": {
+            "options": {
+              "cleanup": true
+            }
+          }
+        }
+      ],
+      "remove": [
+        ".ads",
+        ".tracking"
+      ],
+      "executeClientScripts": true
+    },
+    "Terms of Service": {
+      "fetch": "https://example.com/terms.pdf"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid/minimal-service.json b/scripts/declarations/validate/fixtures/valid/minimal-service.json
@@ -0,0 +1,9 @@
+{
+  "name": "Minimal service",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid/multiple-source-documents.json b/scripts/declarations/validate/fixtures/valid/multiple-source-documents.json
@@ -0,0 +1,24 @@
+{
+  "name": "Multiple source documents service",
+  "terms": {
+    "Privacy Policy": {
+      "combine": [
+        {
+          "fetch": "https://example.com/privacy1",
+          "select": "div.content",
+          "filter": [
+            "removeLinks"
+          ]
+        },
+        {
+          "fetch": "https://example.com/privacy2",
+          "select": ".privacy-section"
+        }
+      ],
+      "select": "body",
+      "filter": [
+        "trimWhitespace"
+      ]
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid/pdf-document.json b/scripts/declarations/validate/fixtures/valid/pdf-document.json
@@ -0,0 +1,8 @@
+{
+  "name": "Service with PDF terms",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy.pdf"
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid/range-selectors.json b/scripts/declarations/validate/fixtures/valid/range-selectors.json
@@ -0,0 +1,19 @@
+{
+  "name": "Service with range selectors",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": [
+        "div.content",
+        {
+          "startBefore": "h1",
+          "endAfter": "footer"
+        },
+        {
+          "startAfter": "h2",
+          "endBefore": ".end-marker"
+        }
+      ]
+    }
+  }
+}
diff --git a/scripts/declarations/validate/fixtures/valid/service-with-filters.json b/scripts/declarations/validate/fixtures/valid/service-with-filters.json
@@ -0,0 +1,22 @@
+{
+  "name": "Service with filters",
+  "terms": {
+    "Privacy Policy": {
+      "fetch": "https://example.com/privacy",
+      "select": "div.content",
+      "filter": [
+        "removeLinks",
+        {
+          "customFilter": {
+            "param": "value"
+          }
+        },
+        {
+          "anotherFilter": {
+            "setting": true
+          }
+        }
+      ]
+    }
+  }
+}
diff --git a/scripts/declarations/validate/schemas.test.js b/scripts/declarations/validate/schemas.test.js
@@ -0,0 +1,105 @@
+import fs from 'fs';
+import path from 'path';
+import { fileURLToPath } from 'url';
+
+import Ajv from 'ajv';
+import addFormats from 'ajv-formats';
+import { expect } from 'chai';
+
+import serviceHistorySchema from './service.history.schema.js';
+import serviceSchema from './service.schema.js';
+
+describe('Schema validation', () => {
+  let validator;
+  const __dirname = path.dirname(fileURLToPath(import.meta.url));
+  const fixturesDir = path.join(__dirname, 'fixtures');
+
+  before(() => {
+    validator = new Ajv({ allErrors: true });
+    addFormats(validator);
+  });
+
+  describe('Service schema', () => {
+    describe('with valid declarations', () => {
+      const validDir = path.join(fixturesDir, 'valid');
+      const files = fs.readdirSync(validDir);
+      const validFiles = files.filter(file => file.endsWith('.json'));
+
+      validFiles.forEach(file => {
+        it(`validates ${file}`, () => {
+          const filePath = path.join(validDir, file);
+          const content = fs.readFileSync(filePath, 'utf8');
+          const declaration = JSON.parse(content);
+
+          const valid = validator.validate(serviceSchema, declaration);
+
+          if (!valid) {
+            console.error(`Validation errors for ${file}:`, validator.errors);
+          }
+
+          expect(valid, `${file} should be valid`).to.be.true;
+        });
+      });
+    });
+
+    describe('with invalid declarations', () => {
+      const invalidDir = path.join(fixturesDir, 'invalid');
+      const files = fs.readdirSync(invalidDir);
+      const invalidFiles = files.filter(file => file.endsWith('.json'));
+
+      invalidFiles.forEach(file => {
+        it(`rejects ${file}`, () => {
+          const filePath = path.join(invalidDir, file);
+          const content = fs.readFileSync(filePath, 'utf8');
+          const declaration = JSON.parse(content);
+
+          const valid = validator.validate(serviceSchema, declaration);
+
+          expect(valid, `${file} should be invalid`).to.be.false;
+        });
+      });
+    });
+  });
+
+  describe('Service history schema', () => {
+    describe('with valid history declarations', () => {
+      const validHistoryDir = path.join(fixturesDir, 'valid-history');
+      const files = fs.readdirSync(validHistoryDir);
+      const validHistoryFiles = files.filter(file => file.endsWith('.json'));
+
+      validHistoryFiles.forEach(file => {
+        it(`validates ${file}`, () => {
+          const filePath = path.join(validHistoryDir, file);
+          const content = fs.readFileSync(filePath, 'utf8');
+          const declaration = JSON.parse(content);
+
+          const valid = validator.validate(serviceHistorySchema, declaration);
+
+          if (!valid) {
+            console.error(`Validation errors for ${file}:`, validator.errors);
+          }
+
+          expect(valid, `${file} should be valid`).to.be.true;
+        });
+      });
+    });
+
+    describe('with invalid history declarations', () => {
+      const invalidHistoryDir = path.join(fixturesDir, 'invalid-history');
+      const files = fs.readdirSync(invalidHistoryDir);
+      const invalidHistoryFiles = files.filter(file => file.endsWith('.json'));
+
+      invalidHistoryFiles.forEach(file => {
+        it(`rejects ${file}`, () => {
+          const filePath = path.join(invalidHistoryDir, file);
+          const content = fs.readFileSync(filePath, 'utf8');
+          const declaration = JSON.parse(content);
+
+          const valid = validator.validate(serviceHistorySchema, declaration);
+
+          expect(valid, `${file} should be invalid`).to.be.false;
+        });
+      });
+    });
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "name": "Service without terms"`
	`3`	`+}`