-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Description
What I was trying to do
- Implement Pinterest history file, see Pinterest history pga-declarations#456
What happened
- All checks failed with error "serviceHistory(termsType) push is not a function", see https://github.com/OpenTermsArchive/pga-declarations/pull/456/checks
What I was hoping to see happen instead
- Checks failed with a useful error such as "History file is not properly formatted, it is missing an array in the terms history".
Additional information
I am sure this is only related to formatting, as the follow-up PR OpenTermsArchive/pga-declarations#461 with corrected formatting passed all checks.
Addition notes
As you can see here OpenTermsArchive/pga-declarations#456, it was solved already by @MattiSG, so it is not urgent to fix a declaration, but you might want to be aware of this for the next times.
Metadata
Metadata
Assignees
Labels
No labels