Skip to content

--modified fails on new filter file #1186

@MattiSG

Description

@MattiSG

In OpenTermsArchive/GenAI-declarations#298, I add a new filter file.

The ota validate declarations --modified fails with the error:

 1) Uncaught error outside test suite:
     Uncaught TypeError: Cannot read properties of undefined (reading 'terms')
      at file:///Users/opentermsarchive/Documents/GenAI-declarations/node_modules/@opentermsarchive/engine/scripts/declarations/utils/index.js:53:65

Which references the source line:

        servicesTermsTypes[serviceId] = Object.keys(declaration.terms); // Considering how rarely filters are used, simply return all term types that could potentially be impacted to spare implementing a function change check

This seems to fail because a new filter file is created, and there is thus no file to compare against in the base branch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions