Skip to content

Commit 17231c3

Browse files
committed
We dont need @State as we arent editing content in the OTIO TImeline, Tracks or Items.
1 parent f0563aa commit 17231c3

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/ItemView.swift

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,13 @@ struct ItemView : View {
4343
)
4444
.frame(width: self.getSafeWidth() - 2)
4545

46-
Text(item.name)
47-
.lineLimit(1)
48-
.font(.system(size: 10))
49-
.frame(width: self.getSafeWidth())
46+
if self.getSafeWidth() > 40
47+
{
48+
Text(item.name)
49+
.lineLimit(1)
50+
.font(.system(size: 10))
51+
.frame(width: self.getSafeWidth())
52+
}
5053
}
5154
}
5255
.frame(width: self.getSafeWidth())

OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/TimeRulerView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import TimecodeKit
1111
import SwiftUI
1212
struct TimeRulerView: View
1313
{
14-
var timeline: OpenTimelineIO.Timeline
14+
let timeline: OpenTimelineIO.Timeline
1515
@Binding var secondsToPixels: Double
1616
@Binding var currentTime: OpenTimelineIO.RationalTime
1717

OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/TimelineView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import SwiftUI
1212

1313
struct TimelineView : View {
1414

15-
var timeline:OpenTimelineIO.Timeline
15+
let timeline:OpenTimelineIO.Timeline
1616

1717
@Binding var currentTime:RationalTime
1818
@Binding var secondsToPixels:Double

OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/TrackView.swift

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ import OpenTimelineIO
1111
import TimecodeKit
1212
import SwiftUI
1313

14+
1415
struct TrackView : View
1516
{
16-
@State var track:OpenTimelineIO.Track
17+
let track:OpenTimelineIO.Track
1718
@State var backgroundColor:Color
1819
@Binding var secondsToPixels:Double
1920
@Binding var selectedItem:Item?
@@ -26,12 +27,13 @@ struct TrackView : View
2627
{
2728
Section(header: self.headerView() )
2829
{
30+
2931
ForEach(0..<items.count, id: \.self) { index in
30-
3132
let item = items[index]
32-
33+
3334
ItemView(item: item,
3435
backgroundColor: self.backgroundColor,
36+
// backgroundColor: [Color.red, Color.blue, Color.green, Color.yellow, Color.purple].randomElement()!,
3537
selected: item.isEquivalent(to: self.selectedItem ?? Item() ),
3638
secondsToPixels: self.$secondsToPixels)
3739

0 commit comments

Comments
 (0)