Skip to content

Commit cbd1a86

Browse files
vadevade
committed
Fix compilation for macOS 13, but we broke
* timeline drawing bounding boxes. * color of text in canvas drawing for playhead
1 parent 2ce9148 commit cbd1a86

File tree

5 files changed

+46
-28
lines changed

5 files changed

+46
-28
lines changed

‎OpenTimelineIO-Sample/OpenTimelineIO-Reader.xcodeproj/project.pbxproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
201201
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
202202
"LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks";
203-
MACOSX_DEPLOYMENT_TARGET = 14.5;
203+
MACOSX_DEPLOYMENT_TARGET = 13.5;
204204
MARKETING_VERSION = "1.0 Beta 1";
205205
PRODUCT_BUNDLE_IDENTIFIER = "ai.ozu.OpenTimelineIO-Reader";
206206
PRODUCT_NAME = "$(TARGET_NAME)";
@@ -242,7 +242,7 @@
242242
IPHONEOS_DEPLOYMENT_TARGET = 18.0;
243243
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
244244
"LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "@executable_path/../Frameworks";
245-
MACOSX_DEPLOYMENT_TARGET = 14.5;
245+
MACOSX_DEPLOYMENT_TARGET = 13.5;
246246
MARKETING_VERSION = "1.0 Beta 1";
247247
PRODUCT_BUNDLE_IDENTIFIER = "ai.ozu.OpenTimelineIO-Reader";
248248
PRODUCT_NAME = "$(TARGET_NAME)";

‎OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/ContentView.swift‎

Lines changed: 36 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,14 @@ struct ContentView: View
2020
@State private var isExportingOTIO: Bool = false
2121
@State private var isExportingMPEG4: Bool = false
2222
@State var secondsToPixels = 10.0;
23-
@State var inspectorOpen: Bool = true
2423

24+
25+
//@State var inspectorOpen: Bool = true
26+
@State var columnVisibility: NavigationSplitViewVisibility = .doubleColumn
27+
2528
@State var selectedItem: OpenTimelineIO.Item? = nil
2629

30+
2731
init(document: OpenTimelineIO_ReaderDocument , fileURL: URL? = nil) {
2832
self.document = document
2933
self.fileURL = fileURL
@@ -37,34 +41,48 @@ struct ContentView: View
3741

3842
var body: some View {
3943

40-
VSplitView
44+
NavigationSplitView(columnVisibility: $columnVisibility)
4145
{
42-
VideoPlayer(player: document.player)
43-
44-
VStack(alignment: .leading)
46+
EmptyView()
47+
}
48+
content:
49+
{
50+
VSplitView
4551
{
46-
Text(document.timeline.name.isEmpty ? "Untitled Timeline" : document.timeline.name)
47-
.padding(.horizontal)
48-
.padding(.top, 5)
49-
50-
TimelineView(timeline: document.timeline,
51-
currentTime: self.$document.currentTime ,
52-
secondsToPixels: self.$secondsToPixels,
53-
selectedItem: self.$selectedItem)
52+
VideoPlayer(player: document.player)
5453

55-
self.controlsViewStack()
54+
VStack(alignment: .leading)
55+
{
56+
Text(document.timeline.name.isEmpty ? "Untitled Timeline" : document.timeline.name)
57+
.padding(.horizontal)
58+
.padding(.top, 5)
59+
60+
TimelineView(timeline: document.timeline,
61+
currentTime: self.$document.currentTime ,
62+
secondsToPixels: self.$secondsToPixels,
63+
selectedItem: self.$selectedItem)
64+
65+
self.controlsViewStack()
66+
}
5667
}
5768
}
58-
.inspector(isPresented: self.$inspectorOpen)
59-
{
69+
detail: {
6070
ItemInspectorView(selectedItem: self.$selectedItem)
61-
.inspectorColumnWidth(min: 250, ideal: 300, max: 500)
71+
// .inspectorColumnWidth(min: 250, ideal: 300, max: 500)
72+
.navigationSplitViewColumnWidth(min:250, ideal: 200, max: 300)
73+
6274
.toolbar
6375
{
6476
Spacer()
6577

6678
Button {
67-
self.inspectorOpen.toggle()
79+
if self.columnVisibility == .detailOnly {
80+
self.columnVisibility = .doubleColumn
81+
}
82+
else
83+
{
84+
self.columnVisibility = .detailOnly
85+
}
6886
} label: {
6987
Image(systemName: "info.circle")
7088
}

‎OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/ItemInspectorView.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ struct ItemInspectorView: View
9494
}
9595
.listSectionSeparator(.hidden)
9696

97-
Section("\(Image(systemName: "gearshape.fill")) JSON", isExpanded: self.$jsonExpanded)
97+
Section("\(Image(systemName: "gearshape.fill")) JSON")
9898
{
9999
Text(self.safeToJSON(item: selectedItem))
100100
.lineLimit(nil)

‎OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/ItemView.swift‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ struct ItemView : View {
2626
if let _ = item as? Gap
2727
{
2828
RoundedRectangle(cornerRadius: 3)
29-
.fill( Color("GapTrackBaseColor") )
3029
.strokeBorder( self.selected ? .white : .clear, lineWidth: 1)
31-
.frame(width: self.getSafeWidth() - 2)
30+
.foregroundStyle( Color("GapTrackBaseColor") )
31+
.frame(width: self.getSafeWidth() - 2)
3232
}
3333
else
3434
{
3535
RoundedRectangle(cornerRadius: 3)
36-
.fill( self.backgroundColor.gradient )
3736
.strokeBorder( self.selected ? .white : .clear, lineWidth: 1)
37+
.foregroundStyle( self.backgroundColor.gradient )
3838
.frame(width: self.getSafeWidth() - 2)
3939

4040
Text(item.name)

‎OpenTimelineIO-Sample/OpenTimelineIO-Reader/Views/TimeRulerView.swift‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ struct TimeRulerView: View
6868
// Draw label if it's an hour or minute
6969
if self.secondsToPixels > 50
7070
{
71-
context.draw(Text(label).font(.system(size: 10)).foregroundStyle(.white), at: CGPoint(x: positionX + 2, y: size.height - tickHeight - 10))
71+
context.draw(Text(label).font(.system(size: 10)), at: CGPoint(x: positionX + 2, y: size.height - tickHeight - 10))
7272
}
7373
}
7474
}
@@ -95,7 +95,7 @@ struct TimeRulerView: View
9595

9696
if self.secondsToPixels > 400
9797
{
98-
context.draw(Text(String(frameNum)).font(.system(size: 10)).foregroundStyle(.white), at: CGPoint(x: positionX, y: size.height - tickHeight - 5))
98+
context.draw(Text(String(frameNum)).font(.system(size: 10)), at: CGPoint(x: positionX, y: size.height - tickHeight - 5))
9999
}
100100
}
101101
}
@@ -117,11 +117,11 @@ struct TimeRulerView: View
117117
let playheadRect = CGRect(x: playheadPositionX, y: 20, width: 1, height: size.height-20)
118118
// context.fill(Path(playheadRect), with: .color(.orange))
119119

120-
context.draw(Text("\(Image(systemName: "arrowtriangle.down.fill"))").font(.system(size: 13)).foregroundStyle(.orange), at: CGPoint(x: playheadPositionX + 0.5, y: 15))
120+
context.draw(Text("\(Image(systemName: "arrowtriangle.down.fill"))").font(.system(size: 13)), at: CGPoint(x: playheadPositionX + 0.5, y: 15))
121121

122122
context.fill(Path(playheadRect), with: .color(.orange))
123123

124-
context.draw( Text(currentTimeLabel).font(.system(size: 10)).foregroundStyle(.orange) , at: CGPoint(x: playheadPositionX, y: 5))
124+
context.draw( Text(currentTimeLabel).font(.system(size: 10)), at: CGPoint(x: playheadPositionX, y: 5))
125125

126126
}
127127

0 commit comments

Comments
 (0)