Skip to content

Commit 00854b6

Browse files
committed
Marker fixes
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
1 parent b488c40 commit 00854b6

File tree

3 files changed

+20
-16
lines changed

3 files changed

+20
-16
lines changed

lib/toucanView/AudioClipItem.cpp

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,22 @@ namespace toucan
6060
_markerLayout = TimeLayout::create(context, timeRange, _layout);
6161
for (const auto& marker : markers)
6262
{
63-
OTIO_NS::TimeRange markerTimeRange = clip->transformed_time_range(
64-
marker->marked_range(),
65-
timeline->tracks());
63+
const OTIO_NS::TimeRange trimmedRange = clip->trimmed_range();
64+
OTIO_NS::TimeRange markerRange(
65+
marker->marked_range().start_time() + trimmedRange.start_time(),
66+
marker->marked_range().duration());
67+
markerRange = clip->transformed_time_range(markerRange, timeline->tracks());
6668
if (timeline->global_start_time().has_value())
6769
{
68-
markerTimeRange = OTIO_NS::TimeRange(
69-
timeline->global_start_time().value() + markerTimeRange.start_time(),
70-
markerTimeRange.duration());
70+
markerRange = OTIO_NS::TimeRange(
71+
timeline->global_start_time().value() + markerRange.start_time(),
72+
markerRange.duration());
7173
}
7274
auto markerItem = MarkerItem::create(
7375
context,
7476
data,
7577
marker,
76-
markerTimeRange,
78+
markerRange,
7779
_markerLayout);
7880
_markerItems.push_back(markerItem);
7981
}

lib/toucanView/MarkerItem.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ namespace toucan
6969
data,
7070
OTIO_NS::dynamic_retainer_cast<OTIO_NS::SerializableObjectWithMetadata>(marker),
7171
timeRange,
72-
"toucan::ClipItem",
72+
"toucan::MarkerItem",
7373
parent);
7474

7575
_marker = marker;
76-
_text = !marker->name().empty() ? marker->name() : "Clip";
76+
_text = !marker->name().empty() ? marker->name() : "Marker";
7777
_color = getMarkerColor(marker->color());
7878

7979
setTooltip(marker->schema_name() + ": " + _text);

lib/toucanView/VideoClipItem.cpp

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,22 @@ namespace toucan
6969
_markerLayout = TimeLayout::create(context, timeRange, _layout);
7070
for (const auto& marker : markers)
7171
{
72-
OTIO_NS::TimeRange markerTimeRange = clip->transformed_time_range(
73-
marker->marked_range(),
74-
timeline->tracks());
72+
const OTIO_NS::TimeRange trimmedRange = clip->trimmed_range();
73+
OTIO_NS::TimeRange markerRange(
74+
marker->marked_range().start_time() + trimmedRange.start_time(),
75+
marker->marked_range().duration());
76+
markerRange = clip->transformed_time_range(markerRange, timeline->tracks());
7577
if (timeline->global_start_time().has_value())
7678
{
77-
markerTimeRange = OTIO_NS::TimeRange(
78-
timeline->global_start_time().value() + markerTimeRange.start_time(),
79-
markerTimeRange.duration());
79+
markerRange = OTIO_NS::TimeRange(
80+
timeline->global_start_time().value() + markerRange.start_time(),
81+
markerRange.duration());
8082
}
8183
auto markerItem = MarkerItem::create(
8284
context,
8385
data,
8486
marker,
85-
markerTimeRange,
87+
markerRange,
8688
_markerLayout);
8789
_markerItems.push_back(markerItem);
8890
}

0 commit comments

Comments
 (0)