Skip to content

Commit ec533f1

Browse files
committed
Make delete_watch_keywords a list
1 parent 4b941ff commit ec533f1

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,10 @@ Example (for being reminded one week after the ctf has finished):
150150

151151
## Log command deletion
152152

153-
To enable logging of deleting messages containing specific keywords, set `delete_watch_keywords` in `config/config.json` to a comma separated list of keywords.
154-
Clear or remove the setting to disable deletion logging.
153+
To enable logging of deleting messages containing specific keywords, set `delete_watch_keywords` in `config/config.json` to an array of strings to watch for.
155154

156155
Example
157156
```
158157
{
159-
"delete_watch_keywords" : "workon, reload, endctf"
158+
"delete_watch_keywords" : ["workon", "reload", "endctf"]
160159
}

config/config.json.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"wolfram_app_id" : "",
99
"archive_ctf_reminder_offset" : "168",
1010
"archive_everything": true,
11-
"delete_watch_keywords" : "",
11+
"delete_watch_keywords" : [],
1212
"intro_message" : "",
1313
"private_ctfs": false,
1414
"allow_signup": false,

server/botserver.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,16 +96,14 @@ def parse_slack_message(self, message_list):
9696
self.slack_wrapper.post_message(msg['channel'], warning)
9797
# Check for deletion of messages containing keywords
9898
elif "subtype" in msg and msg["subtype"] == "message_deleted":
99-
log_deletions = self.get_config_option("delete_watch_keywords")
99+
delete_keywords = self.get_config_option("delete_watch_keywords")
100100

101-
if log_deletions:
102-
previous_msg = msg['previous_message']['text']
103-
delete_keywords = log_deletions.split(",")
101+
previous_msg = msg['previous_message']['text']
104102

105-
if any(keyword.strip() in previous_msg for keyword in delete_keywords):
106-
user_name = self.slack_wrapper.get_member(msg['previous_message']['user'])
107-
display_name = get_display_name(user_name)
108-
self.slack_wrapper.post_message(msg['channel'], "*{}* deleted : `{}`".format(display_name, previous_msg))
103+
if any(keyword in previous_msg for keyword in delete_keywords):
104+
user_name = self.slack_wrapper.get_member(msg["previous_message"]["user"])
105+
display_name = get_display_name(user_name)
106+
self.slack_wrapper.post_message(msg['channel'], "*{}* deleted : `{}`".format(display_name, previous_msg))
109107
# Greet new users
110108
elif msg.get("type") == "im_created":
111109
self.slack_wrapper.post_message(msg['user'], self.get_config_option("intro_message"))

0 commit comments

Comments
 (0)