Merge pull request #619 from OpenVADL/bugfix/fix-large-constant-lowering-bug

lowering: Fix bug in constant lowering with large constants

Author: flofriday

sys/ppc64/ppc64.vadl

@@ -432,14 +432,12 @@ instruction set architecture PPC64SFS = {
      fxm(3) as SNibble, fxm(2) as SNibble,
      fxm(1) as SNibble, fxm(0) as SNibble)
 
-  // TODO: remove
-  constant msrtrap : Bits<64> = 0x8000000000001000
   // triggered by the tw and twi instructions if at least one trap condition evaluates to true
   exception Trap () = {
     SRR0 := PC
     SRR1 := (MSR(63..31), 0 as Nibble, MSR(26..22), 0 as Nibble, 1 as Bits<1>, 0 as Bits<1>, MSR(15..0))
     PC   := 0x0000'0000'0000'0700
-    MSR  := msrtrap
+    MSR  := 0x8000000000001000
   }
 
   // triggered when a privileged instruction gets called in an unprivileged processor state

vadl/main/vadl/ast/BehaviorLowering.java

@@ -1388,10 +1388,10 @@ public ExpressionNode visit(CastExpr expr) {
     // Shortcut for constant types
     var viamType = getViamType(expr.type());
     if (expr.value.type instanceof ConstantType constType) {
-      return new ConstantNode(
-          Constant.Value.of(constType.getValue().longValueExact(),
-                  (DataType) constType.closestTo(viamType))
-              .castTo((DataType) viamType));
+      return Constant.Value.fromInteger(constType.getValue(),
+              (DataType) constType.closestTo(viamType))
+          .castTo((DataType) viamType)
+          .toNode();
     }
 
     // check the different rules and apply them accordingly

vadl/test/resources/diagnostics/lowering/exceptionWithConstantValue.vadl

@@ -0,0 +1,18 @@
+// This was a bug before
+// https://github.com/OpenVADL/openvadl/issues/616
+
+instruction set architecture ISA = {
+  register MSR  :  Bits<64>
+
+  exception Trap () = {
+    MSR  := 0x8000000000001000
+  }
+}
+
+
+// Reported Diagnostics:
+//
+//  No diagnostics were reported, the input was correctly parsed, typechecked and lowered.
+//
+//
+// Part of the class vadl.ast.DiagnosticsTest