frontend: Cannot join source locations that point to different files.

[AndreasKrall]

When I have an erroneous specification which imports from a file, like:

import aarch64::AArch64Base

instruction set architecture AArch64SVEandSME extending AArch64Base = {
some error
}

VADL crashes with the following stack trace:

                             ___ ___    _   ___ _  _
                            / __| _ \  /_\ / __| || |
                           | (__|   / / _ \\__ \ __ |
                            \___|_|_\/_/ \_\___/_||_|

                       🔥 The OpenVADL compiler crashed 🔥

This shouldn't have happened, please open an issue with the stacktrace below at:
https://github.com/OpenVADL/open-vadl/issues/new


java.lang.IllegalArgumentException: Cannot join source locations that point to different files.
	at vadl.utils.SourceLocation.join(SourceLocation.java:114)
	at vadl.ast.Parser.callOrBinaryExpression(Parser.java:1472)
	at vadl.ast.Parser.term(Parser.java:2848)
	at vadl.ast.Parser.expression(Parser.java:939)
	at vadl.ast.Parser.argument(Parser.java:3065)
	at vadl.ast.Parser.arguments(Parser.java:3042)
	at vadl.ast.Parser.callOrBinaryExpression(Parser.java:1457)
	at vadl.ast.Parser.term(Parser.java:2848)
	at vadl.ast.Parser.expression(Parser.java:939)
	at vadl.ast.Parser.letStatement(Parser.java:2606)
	at vadl.ast.Parser.statement(Parser.java:1319)
	at vadl.ast.Parser.instructionDefinition(Parser.java:1016)
	at vadl.ast.Parser.isaDefinition(Parser.java:887)
	at vadl.ast.Parser.isaDefinitionList(Parser.java:860)
	at vadl.ast.Parser.macroBody(Parser.java:3781)
	at vadl.ast.Parser.macroDef(Parser.java:414)
	at vadl.ast.Parser.isaDefinitionList(Parser.java:863)
	at vadl.ast.Parser.instructionsetDefinition(Parser.java:460)
	at vadl.ast.Parser.topLevelDefinitions(Parser.java:355)
	at vadl.ast.Parser.vadl(Parser.java:327)
	at vadl.ast.Parser.Parse(Parser.java:3885)
	at vadl.ast.VadlParser.parse(VadlParser.java:115)
	at vadl.ast.VadlParser.parse(VadlParser.java:62)
	at vadl.cli.BaseCommand.parseToAst(BaseCommand.java:167)
	at vadl.cli.BaseCommand.parseToVIAM(BaseCommand.java:248)
	at vadl.cli.BaseCommand.call(BaseCommand.java:329)
	at vadl.cli.BaseCommand.call(BaseCommand.java:66)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2045)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
	at picocli.CommandLine.execute(CommandLine.java:2174)
	at vadl.cli.Main.main(Main.java:44)
	at java.base@25.0.1/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)

[flofriday]

I can't seem to reproduce the error :/
Is that actual the content you had in your file, because maybe it's specific to the error beeing thrown.

[AndreasKrall]

There were some specific wrong macros. I will try to get a small example which triggers this error.

[AndreasKrall]

The following code triggers the crash:

import aarch64::AArch64Base

instruction set architecture AArch64SVEandSME extending AArch64Base = {

  model AddSubExtInstrBase (i: InstrWithFunct, extId: Id, size: Id, f: Flags, extEx: Ex, optId: Id, enc: Encs, asm: Ex): IsaDefs = {
    [undefined when : imm3(2) = 1 && imm3(1..0) != 0]
    instruction AsId ($i.id, $extId): AddSubExtFormat =
      let result, flags = VADL::$i.funct ($RSReg($size)(rn), ($extEx) as Bits<Size::$size>) in {
        $f.resModel (match: Id ($f.ff = OffFlags => $RSReg($size) ; _ => $WXReg($size))(rd) ; result )
        }
    encoding AsId ($i.id, $extId) = { op = $i.opcode, sf = SF::$size, ff = FF::$f.ff, option = ExtendType::$optId, $enc }
    assembly AsId ($i.id, $extId) = ( $i.mnemo, $f.mext, ' ', AsId($size, match: Str ($f.ff = OffFlags => "SP" ; _ => ""))(rd),
                       ', ', AsId($size, "SP")(rn), ', ', $asm )
    }

}