typechecker: Improve const casting for builtins#810
Merged
Conversation
github-actions
bot
added
enhancement
flofriday
force-pushed
the
feature/improve-typechecking-for-builtins
branch
2 times, most recently
from
73bb563 to
3528356
Compare
Jozott00
approved these changes
Mar 12, 2026
vadl/test/resources/frontend-snapshots/typechecker/assemblyBuiltinWithoutCast.vadl
Outdated
Show resolved
Hide resolved
benjaminkasper99
requested changes
Mar 12, 2026
Contributor
benjaminkasper99
left a comment
benjaminkasper99
left a comment
There was a problem hiding this comment.
Constants work as expected now, but there is one issue I described below.
flofriday
force-pushed
the
feature/improve-typechecking-for-builtins
branch
from
3528356 to
affc877
Compare
flofriday
force-pushed
the
feature/improve-typechecking-for-builtins
branch
from
affc877 to
12fec13
Compare
benjaminkasper99
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #787