Enhance VPN Regions test coverage with comprehensive test cases

Signed-off-by: Denis Arslanbekov <denis@arslanbekov.com>

Author: arslanbekov

cloudconnexa/vpn_regions_test.go

@@ -9,35 +9,121 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+var testVpnRegion = VpnRegion{
+	ID:         "test-region",
+	Country:    "Test Country",
+	Continent:  "Test Continent",
+	CountryISO: "TC",
+	RegionName: "Test Region",
+}
+
 func TestVPNRegionsService_GetByPage(t *testing.T) {
 	// Create test server
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// Handle auth token request
+		if r.URL.Path == "/api/v1/oauth/token" {
+			w.Header().Set("Content-Type", "application/json")
+			err := json.NewEncoder(w).Encode(map[string]string{
+				"access_token": "test-token",
+			})
+			assert.NoError(t, err)
+			return
+		}
+
+		// Handle VPN regions request
 		assert.Equal(t, "/api/v1/vpn-regions", r.URL.Path)
 		assert.Equal(t, "page=0&size=10", r.URL.RawQuery)
 
 		response := VPNRegionPageResponse{
-			Content: []VpnRegion{
-				{
-					ID:         "test-region",
-					Country:    "Test Country",
-					Continent:  "Test Continent",
-					CountryISO: "TC",
-				},
-			},
+			Content:          []VpnRegion{testVpnRegion},
 			Success:          true,
 			NumberOfElements: 1,
 			TotalElements:    1,
 		}
 
-		json.NewEncoder(w).Encode(response)
+		err := json.NewEncoder(w).Encode(response)
+		assert.NoError(t, err)
 	}))
 	defer server.Close()
 
-	client, _ := NewClient(server.URL, "test", "test")
+	client, err := NewClient(server.URL, "test", "test")
+	assert.NoError(t, err)
 	response, err := client.VPNRegions.GetByPage(0, 10)
 
 	assert.NoError(t, err)
 	assert.True(t, response.Success)
 	assert.Equal(t, 1, len(response.Content))
-	assert.Equal(t, "test-region", response.Content[0].ID)
+	assert.Equal(t, testVpnRegion.ID, response.Content[0].ID)
+}
+
+func TestVPNRegionsService_List(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// Handle auth token request
+		if r.URL.Path == "/api/v1/oauth/token" {
+			w.Header().Set("Content-Type", "application/json")
+			err := json.NewEncoder(w).Encode(map[string]string{
+				"access_token": "test-token",
+			})
+			assert.NoError(t, err)
+			return
+		}
+
+		// Handle VPN regions request
+		assert.Equal(t, "/api/v1/vpn-regions", r.URL.Path)
+
+		response := VPNRegionPageResponse{
+			Content:          []VpnRegion{testVpnRegion},
+			Success:          true,
+			NumberOfElements: 1,
+			TotalElements:    1,
+			TotalPages:       1,
+		}
+
+		err := json.NewEncoder(w).Encode(response)
+		assert.NoError(t, err)
+	}))
+	defer server.Close()
+
+	client, err := NewClient(server.URL, "test", "test")
+	assert.NoError(t, err)
+	regions, err := client.VPNRegions.List()
+
+	assert.NoError(t, err)
+	assert.Equal(t, 1, len(regions))
+	assert.Equal(t, testVpnRegion.ID, regions[0].ID)
+}
+
+func TestVPNRegionsService_GetByID(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// Handle auth token request
+		if r.URL.Path == "/api/v1/oauth/token" {
+			w.Header().Set("Content-Type", "application/json")
+			err := json.NewEncoder(w).Encode(map[string]string{
+				"access_token": "test-token",
+			})
+			assert.NoError(t, err)
+			return
+		}
+
+		// Handle VPN regions request
+		assert.Equal(t, "/api/v1/regions", r.URL.Path)
+
+		err := json.NewEncoder(w).Encode([]VpnRegion{testVpnRegion})
+		assert.NoError(t, err)
+	}))
+	defer server.Close()
+
+	client, err := NewClient(server.URL, "test", "test")
+	assert.NoError(t, err)
+
+	// Test existing region
+	region, err := client.VPNRegions.GetByID(testVpnRegion.ID)
+	assert.NoError(t, err)
+	assert.NotNil(t, region)
+	assert.Equal(t, testVpnRegion.ID, region.ID)
+
+	// Test non-existent region
+	region, err = client.VPNRegions.GetByID("non-existent")
+	assert.NoError(t, err)
+	assert.Nil(t, region)
 }