Refactor HTTP header setting logic into reusable helper function - Add setCommonHeaders helper to centralize Authorization, User-Agent, and Content-Type header logic - Improve maintainability by reducing code duplication across HTTP requests - Preserve existing behavior while enhancing code organization

Author: arslanbekov

cloudconnexa/cloudconnexa.go

@@ -139,6 +139,18 @@ func NewClient(baseURL, clientID, clientSecret string) (*Client, error) {
 	return c, nil
 }
 
+// setCommonHeaders sets the standard headers for API requests.
+// It sets Authorization and User-Agent headers, and sets Content-Type to application/json
+// if no Content-Type header is already present.
+func (c *Client) setCommonHeaders(req *http.Request) {
+	req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", c.Token))
+	req.Header.Set("User-Agent", c.UserAgent)
+
+	if req.Header.Get("Content-Type") == "" {
+		req.Header.Set("Content-Type", "application/json")
+	}
+}
+
 // DoRequest executes an HTTP request with authentication and rate limiting.
 // It automatically adds the Bearer token, sets headers, and handles errors.
 func (c *Client) DoRequest(req *http.Request) ([]byte, error) {
@@ -147,11 +159,7 @@ func (c *Client) DoRequest(req *http.Request) ([]byte, error) {
 		return nil, err
 	}
 
-	req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", c.Token))
-	req.Header.Set("User-Agent", c.UserAgent)
-	if req.Header.Get("Content-Type") == "" {
-		req.Header.Set("Content-Type", "application/json")
-	}
+	c.setCommonHeaders(req)
 
 	res, err := c.client.Do(req)
 	if err != nil {

cloudconnexa/settings.go

@@ -391,10 +391,10 @@ func (c *SettingsService) getString(path string) (string, error) {
 func (c *SettingsService) setString(path string, value string) (string, error) {
 	endpoint := fmt.Sprintf("%s/settings"+path, c.client.GetV1Url())
 	req, err := http.NewRequest(http.MethodPut, endpoint, bytes.NewBuffer([]byte(value)))
-	req.Header.Set("Content-Type", "text/plain")
 	if err != nil {
 		return "", err
 	}
+	req.Header.Set("Content-Type", "text/plain")
 	body, err := c.client.DoRequest(req)
 	if err != nil {
 		return "", err