Skip to content

Remove File's reliance on std::variant for buffer #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Spartan322 merged 1 commit into from
Apr 4, 2025
Merged

Remove File's reliance on std::variant for buffer #78

Spartan322 merged 1 commit into from
Apr 4, 2025

Conversation

@Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Mar 29, 2025

@Spartan322 Spartan322 added the enhancement New feature or request label Mar 29, 2025
@Spartan322 Spartan322 force-pushed the remove/file-variant branch 2 times, most recently from 160fda0 to 85c7859 Compare March 29, 2025 17:29
Base automatically changed from simplify/conversion to master April 4, 2025 19:05
@Spartan322 Spartan322 marked this pull request as ready for review April 4, 2025 19:08
@Spartan322 Spartan322 force-pushed the remove/file-variant branch from 85c7859 to 2bb27e6 Compare April 4, 2025 19:13
@Spartan322 Spartan322 enabled auto-merge April 4, 2025 19:29
@Spartan322 Spartan322 merged commit 5a281b1 into master Apr 4, 2025
16 checks passed
@Hop311 Hop311 deleted the remove/file-variant branch April 4, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hop311 Hop311 Hop311 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Spartan322 @Hop311