Merge pull request #621 from OpenVicProject/fix_specialization_after_instantiation

wvpm · web-flow · commit 0077e6be9a98 · 2025-11-05T08:58:14.000+01:00
Fix fp formatting specialization after instantiation
diff --git a/src/openvic-simulation/types/fixed_point/FixedPoint.hpp b/src/openvic-simulation/types/fixed_point/FixedPoint.hpp
@@ -192,7 +192,11 @@ namespace OpenVic {
 #ifdef DEV_ENABLED
 			if (!std::is_constant_evaluated()) {
 				if (OV_unlikely(value < ONE)) {
-					spdlog::warn_s("Fixed point {} < 1, truncation will result in zero, this may be a bug.", *this);
+					spdlog::warn_s(
+						"Fixed point < 1, truncation will result in zero, this may be a bug. raw_value: {} as float: {}",
+						get_raw_value(),
+						static_cast<float>(*this)
+					);
 				}
 			}
 #endif

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,11 @@ namespace OpenVic {`
`192`	`192`	`#ifdef DEV_ENABLED`
`193`	`193`	`if (!std::is_constant_evaluated()) {`
`194`	`194`	`if (OV_unlikely(value < ONE)) {`
`195`		`- spdlog::warn_s("Fixed point {} < 1, truncation will result in zero, this may be a bug.", *this);`
	`195`	`+ spdlog::warn_s(`
	`196`	`+ "Fixed point < 1, truncation will result in zero, this may be a bug. raw_value: {} as float: {}",`
	`197`	`+ get_raw_value(),`
	`198`	`+ static_cast<float>(*this)`
	`199`	`+ );`
`196`	`200`	`}`
`197`	`201`	`}`
`198`	`202`	`#endif`