Merge pull request #653 from OpenVicProject/fix/clang-tidy

Apply suggested clang-tidy fixes

Author: Spartan322

src/openvic-simulation/dataloader/Vic2PathSearch_Windows.hpp

@@ -1,4 +1,5 @@
 #pragma once
+#ifdef _WIN32
 
 #include <concepts>
 #pragma comment(lib, "advapi32.lib")
@@ -160,3 +161,4 @@ namespace OpenVic::Windows {
 		return ReadRegValue<RCHAR_T>(root, key_sv, name_sv);
 	}
 }
+#endif

src/openvic-simulation/economy/production/ProductionType.hpp

@@ -101,7 +101,7 @@ namespace OpenVic {
 	struct ProductionTypeManager {
 	private:
 		IdentifierRegistry<ProductionType> IDENTIFIER_REGISTRY(production_type);
-		pop_sprite_t PROPERTY(rgo_owner_sprite);
+		pop_sprite_t PROPERTY(rgo_owner_sprite, 0);
 		OV_IFLATMAP_PROPERTY(GoodDefinition, ProductionType const*, good_to_rgo_production_type);
 
 		NodeTools::node_callback_t _expect_job(
@@ -115,8 +115,7 @@ namespace OpenVic {
 
 	public:
 		constexpr ProductionTypeManager()
-			: rgo_owner_sprite { 0 },
-			good_to_rgo_production_type { decltype(good_to_rgo_production_type)::create_empty() } {}
+			: good_to_rgo_production_type { decltype(good_to_rgo_production_type)::create_empty() } {}
 
 		bool add_production_type(
 			GameRulesManager const& game_rules_manager,

src/openvic-simulation/types/HasIndex.hpp

@@ -1,9 +1,10 @@
 #pragma once
 
 #include <concepts>
+#include <cstddef>
 
 namespace OpenVic {
-	template<typename TypeTag, std::integral IndexT = size_t>
+	template<typename TypeTag, std::integral IndexT = std::size_t>
 	class HasIndex {
 	public:
 		using index_t = IndexT;