Skip to content

Commit d52dc9b

Browse files
committed
ov-components: Remove old and unnecessary test and refactored code
1 parent b2e50aa commit d52dc9b

File tree

3 files changed

+25
-52
lines changed

3 files changed

+25
-52
lines changed

openvidu-components-angular/e2e/nested-components/directives.test.ts

Lines changed: 18 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
import { expect } from 'chai';
22
import { Builder, By, WebDriver } from 'selenium-webdriver';
33

4-
import { AngularConfig } from '../selenium.conf';
4+
import { NestedConfig } from '../selenium.conf';
55
import { OpenViduComponentsPO } from '../utils.po.test';
66

7-
const url = AngularConfig.appUrl;
7+
const url = NestedConfig.appUrl;
88

99
describe('Testing TOOLBAR STRUCTURAL DIRECTIVES', () => {
1010
let browser: WebDriver;
1111
let utils: OpenViduComponentsPO;
1212
async function createChromeBrowser(): Promise<WebDriver> {
1313
return await new Builder()
14-
.forBrowser(AngularConfig.browserName)
15-
.withCapabilities(AngularConfig.browserCapabilities)
16-
.setChromeOptions(AngularConfig.browserOptions)
17-
.usingServer(AngularConfig.seleniumAddress)
14+
.forBrowser(NestedConfig.browserName)
15+
.withCapabilities(NestedConfig.browserCapabilities)
16+
.setChromeOptions(NestedConfig.browserOptions)
17+
.usingServer(NestedConfig.seleniumAddress)
1818
.build();
1919
}
2020

@@ -147,10 +147,10 @@ describe('Testing PANEL STRUCTURAL DIRECTIVES', () => {
147147

148148
async function createChromeBrowser(): Promise<WebDriver> {
149149
return await new Builder()
150-
.forBrowser(AngularConfig.browserName)
151-
.withCapabilities(AngularConfig.browserCapabilities)
152-
.setChromeOptions(AngularConfig.browserOptions)
153-
.usingServer(AngularConfig.seleniumAddress)
150+
.forBrowser(NestedConfig.browserName)
151+
.withCapabilities(NestedConfig.browserCapabilities)
152+
.setChromeOptions(NestedConfig.browserOptions)
153+
.usingServer(NestedConfig.seleniumAddress)
154154
.build();
155155
}
156156

@@ -669,10 +669,10 @@ describe('Testing LAYOUT STRUCTURAL DIRECTIVES', () => {
669669

670670
async function createChromeBrowser(): Promise<WebDriver> {
671671
return await new Builder()
672-
.forBrowser(AngularConfig.browserName)
673-
.withCapabilities(AngularConfig.browserCapabilities)
674-
.setChromeOptions(AngularConfig.browserOptions)
675-
.usingServer(AngularConfig.seleniumAddress)
672+
.forBrowser(NestedConfig.browserName)
673+
.withCapabilities(NestedConfig.browserCapabilities)
674+
.setChromeOptions(NestedConfig.browserOptions)
675+
.usingServer(NestedConfig.seleniumAddress)
676676
.build();
677677
}
678678

@@ -767,10 +767,10 @@ describe('Testing ATTRIBUTE DIRECTIVES', () => {
767767

768768
async function createChromeBrowser(): Promise<WebDriver> {
769769
return await new Builder()
770-
.forBrowser(AngularConfig.browserName)
771-
.withCapabilities(AngularConfig.browserCapabilities)
772-
.setChromeOptions(AngularConfig.browserOptions)
773-
.usingServer(AngularConfig.seleniumAddress)
770+
.forBrowser(NestedConfig.browserName)
771+
.withCapabilities(NestedConfig.browserCapabilities)
772+
.setChromeOptions(NestedConfig.browserOptions)
773+
.usingServer(NestedConfig.seleniumAddress)
774774
.build();
775775
}
776776

@@ -1049,31 +1049,4 @@ describe('Testing ATTRIBUTE DIRECTIVES', () => {
10491049

10501050
expect(await utils.isPresent('ov-broadcasting-activity')).to.be.false;
10511051
});
1052-
1053-
it('should SHOW STREAMING ERROR', async () => {
1054-
await browser.get(`${url}`);
1055-
1056-
await utils.clickOn('#ovActivitiesPanel-checkbox');
1057-
1058-
await utils.clickOn('#broadcastingError-checkbox');
1059-
1060-
await utils.clickOn('#apply-btn');
1061-
1062-
await utils.checkToolbarIsPresent();
1063-
1064-
await utils.clickOn('#activities-panel-btn');
1065-
1066-
await browser.sleep(500);
1067-
1068-
await utils.waitForElement('#custom-activities-panel');
1069-
1070-
const status = await utils.waitForElement('#broadcasting-status');
1071-
1072-
expect(await status.getAttribute('innerText')).equals('FAILED');
1073-
1074-
await utils.clickOn('#broadcasting-activity');
1075-
await browser.sleep(500);
1076-
const error = await utils.waitForElement('#broadcasting-error');
1077-
expect(await error.getAttribute('innerText')).equals('TEST_ERROR');
1078-
});
10791052
});

openvidu-components-angular/e2e/nested-components/events.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
import { expect } from 'chai';
22
import { Builder, By, WebDriver } from 'selenium-webdriver';
33

4-
import { AngularConfig } from '../selenium.conf';
4+
import { NestedConfig } from '../selenium.conf';
55
import { OpenViduComponentsPO } from '../utils.po.test';
66

7-
const url = AngularConfig.appUrl;
7+
const url = NestedConfig.appUrl;
88

99
describe('Testing EVENTS', () => {
1010
let browser: WebDriver;
1111
let utils: OpenViduComponentsPO;
1212

1313
async function createChromeBrowser(): Promise<WebDriver> {
1414
return await new Builder()
15-
.forBrowser(AngularConfig.browserName)
16-
.withCapabilities(AngularConfig.browserCapabilities)
17-
.setChromeOptions(AngularConfig.browserOptions)
18-
.usingServer(AngularConfig.seleniumAddress)
15+
.forBrowser(NestedConfig.browserName)
16+
.withCapabilities(NestedConfig.browserCapabilities)
17+
.setChromeOptions(NestedConfig.browserOptions)
18+
.usingServer(NestedConfig.seleniumAddress)
1919
.build();
2020
}
2121

openvidu-components-angular/e2e/selenium.conf.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const WebComponentConfig: BrowserConfig = {
5454
browserOptions: new chrome.Options().addArguments(...(LAUNCH_MODE === 'CI' ? chromeArgumentsCI : chromeArguments))
5555
};
5656

57-
export const AngularConfig: BrowserConfig = {
57+
export const NestedConfig: BrowserConfig = {
5858
appUrl: 'http://localhost:4200/#/testing',
5959
seleniumAddress: LAUNCH_MODE === 'CI' ? 'http://localhost:3000/webdriver' : '',
6060
browserName: 'Chrome',

0 commit comments

Comments
 (0)