Skip to content

Commit 1140ece

Browse files
Fix: remove rdma support (#1334)
The RDMA support will not be maintained supported the library has a specific purpose, and RDMA is not expected to be used. This was added as an experimental feature, so supporting this is not needed anymore. The performance of this experimental feature was poor. The idea of sending buffers as small as MTU via RDMA was not the brightest one.
1 parent 0b42e0a commit 1140ece

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+11
-5170
lines changed

.github/workflows/coverity.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
libnuma-dev libjson-c-dev libpcap-dev libgtest-dev libsdl2-dev \
3939
libsdl2-ttf-dev libssl-dev ca-certificates m4 clang llvm zlib1g-dev \
4040
libelf-dev libcap-ng-dev libcap2-bin gcc-multilib systemtap-sdt-dev ninja-build \
41-
nasm librdmacm-dev wget unzip && \
41+
nasm wget unzip && \
4242
sudo apt-get clean && \
4343
sudo rm -rf /var/lib/apt/lists/*
4444

ATTRIBUTION.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232
| Libbpf | [Libbpf](https://github.com/libbpf/libbpf) | LGPL-2.1 OR BSD-2-Clause |
3333
| Libxdp | [Libxdp](https://github.com/xdp-project/xdp-tools/tree/master) | LGPL-2.1 OR BSD-2-Clause |
3434
| Gstreamer | [GStreamer](https://github.com/GStreamer/gstreamer) | LGPL v2.1 |
35-
| libibverbs | [libibverbs](https://github.com/linux-rdma/rdma-core/blob/master/libibverbs) | GPLv2 |
36-
| librdmacm | [librdmacm](https://github.com/linux-rdma/rdma-core/tree/master/librdmacm) | GPLv2 |
3735
| level-zero | [Level Zero](https://github.com/oneapi-src/level-zero) | MIT |
3836
| level-zero-dev | [Level Zero Dev](https://github.com/oneapi-src/level-zero) | MIT |
3937
| xpu-smi | [XPU SMI](https://github.com/intel/xpumanager) | MIT |

app/meson.build

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -513,46 +513,6 @@ executable('V4l2toIPApp', v4l2_to_ip_sources,
513513
)
514514
endif
515515

516-
mtl_rdma = dependency('mtl_rdma', required: false)
517-
if mtl_rdma.found()
518-
executable('RdmaTxSample', rdma_tx_sample_sources,
519-
c_args : app_c_args,
520-
link_args: app_ld_args,
521-
# asan should be always the first dep
522-
dependencies: [asan_dep, libpthread, mtl_rdma]
523-
)
524-
executable('RdmaRxSample', rdma_rx_sample_sources,
525-
c_args : app_c_args,
526-
link_args: app_ld_args,
527-
# asan should be always the first dep
528-
dependencies: [asan_dep, libpthread, mtl_rdma]
529-
)
530-
executable('RdmaVideoTxSample', rdma_video_tx_sample_sources,
531-
c_args : app_c_args,
532-
link_args: app_ld_args,
533-
# asan should be always the first dep
534-
dependencies: [asan_dep, libpthread, mtl_rdma]
535-
)
536-
executable('RdmaVideoRxSample', rdma_video_rx_sample_sources,
537-
c_args : app_c_args,
538-
link_args: app_ld_args,
539-
# asan should be always the first dep
540-
dependencies: [asan_dep, libpthread, mtl_rdma, libsdl2]
541-
)
542-
executable('RdmaVideoTxMultiSample', rdma_video_tx_multi_sample_sources,
543-
c_args : app_c_args,
544-
link_args: app_ld_args,
545-
# asan should be always the first dep
546-
dependencies: [asan_dep, libpthread, mtl_rdma]
547-
)
548-
executable('RdmaVideoRxMultiSample', rdma_video_rx_multi_sample_sources,
549-
c_args : app_c_args,
550-
link_args: app_ld_args,
551-
# asan should be always the first dep
552-
dependencies: [asan_dep, libpthread, mtl_rdma, libsdl2]
553-
)
554-
endif
555-
556516
if gpu_direct.found()
557517
executable('GpuDirectVideoTxMultiSample', gpu_direct_tx_sample_sources,
558518
c_args : app_c_args,

app/sample/README.md

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -227,41 +227,3 @@ The runtime log summarizes the number of metadata entries and UDW bytes received
227227
```bash
228228
./build/app/RxSt20pDynExtFrameSample --p_port 0000:af:01.1 --p_sip 192.168.75.22 --p_rx_ip 239.168.75.20
229229
```
230-
231-
## 9. RDMA sample
232-
233-
[rdma_tx.c](rdma/rdma_tx.c): A tx application based on rdma interface.
234-
235-
```bash
236-
./build/app/RdmaTxSample 192.168.75.10 20000
237-
```
238-
239-
[rdma_rx.c](rdma/rdma_rx.c): A rx application based on rdma interface.
240-
241-
```bash
242-
./build/app/RdmaRxSample 192.168.75.11 192.168.75.10 20000
243-
```
244-
245-
[rdma_video_tx.c](rdma/rdma_video_tx.c): A tx video application based on rdma interface. The default video format is 1920x1080 UYVY frame, and the default video frame rate is 30.
246-
247-
```bash
248-
./build/app/RdmaVideoTxSample 192.168.75.10 20000 test.yuv
249-
```
250-
251-
[rdma_video_rx.c](rdma/rdma_video_rx.c): A rx video application based on rdma interface. SDL display is enabled by default.
252-
253-
```bash
254-
./build/app/RdmaVideoRxSample 192.168.75.11 192.168.75.10 20000
255-
```
256-
257-
[rdma_video_tx_multi.c](rdma/rdma_video_tx_multi.c): A tx video application based on rdma interface using multiple queue pair, just for experimental use. The default video format is 1920x1080 UYVY frame, and the default video frame rate is 30.
258-
259-
```bash
260-
numactl -m 0 ./build/app/RdmaVideoTxMultiSample 192.168.75.10 20000 20001 test.yuv
261-
```
262-
263-
[rdma_video_rx_multi.c](rdma/rdma_video_rx_multi.c): A rx video application based on rdma interface using multiple queue pair, just for experimental use. SDL display is enabled by default.
264-
265-
```bash
266-
numactl -m 0 ./build/app/RdmaVideoRxMultiSample 192.168.75.11 192.168.75.10 20000 20001
267-
```

app/sample/meson.build

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,6 @@ dma_sample_sources = files('dma/dma_sample.c', 'sample_util.c')
5050
redundant_rx_st20_combined_sample_sources = files('experimental/rx_st20_redundant_combined_sample.c',
5151
'sample_util.c')
5252

53-
# rdma
54-
rdma_tx_sample_sources = files('rdma/rdma_tx.c')
55-
rdma_rx_sample_sources = files('rdma/rdma_rx.c')
56-
rdma_video_tx_sample_sources = files('rdma/rdma_video_tx.c')
57-
rdma_video_rx_sample_sources = files('rdma/rdma_video_rx.c')
58-
rdma_video_tx_multi_sample_sources = files('rdma/rdma_video_tx_multi.c')
59-
rdma_video_rx_multi_sample_sources = files('rdma/rdma_video_rx_multi.c')
60-
6153
# gpu direct
6254
gpu_direct_tx_sample_sources = files('gpu_direct/tx_st20_pipeline_gpu_direct.c', 'sample_util.c')
6355
gpu_direct_rx_sample_sources = files('gpu_direct/rx_st20_pipeline_gpu_direct.c', 'sample_util.c')

app/sample/rdma/rdma_rx.c

Lines changed: 0 additions & 111 deletions
This file was deleted.

app/sample/rdma/rdma_tx.c

Lines changed: 0 additions & 130 deletions
This file was deleted.

0 commit comments

Comments
 (0)