Skip to content

Commit 46e88cb

Browse files
committed
Fixed: Added more verbose output to terminal
Fixed: Set an timeout to 12h as tests can be lengthy Signed-off-by: Milosz Linkiewicz <[email protected]>
1 parent e9eb56a commit 46e88cb

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

.github/workflows/validation-tests.yml

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,11 @@ jobs:
189189
python3 -m pipenv install -r requirements.txt
190190
echo "VIRTUAL_ENV=$(python3 -m pipenv --venv)/bin/activate" >> "$GITHUB_ENV"
191191
192+
# Timeout of this job is set to 12h [60m/h*12h=720m]
192193
validation-run-tests:
193194
needs: [validation-build-mtl]
194195
runs-on: [Linux, self-hosted, DPDK]
196+
timeout-minutes: 720
195197
env:
196198
PYTEST_ALIAS: 'sudo --preserve-env python3 -m pipenv run pytest'
197199
PYTEST_PARAMS: '--media=/mnt/media --build="../.."'
@@ -239,6 +241,7 @@ jobs:
239241
working-directory: tests/validation
240242
run: |
241243
set +e
244+
echo "::group::pre-execution-summary"
242245
export TEST_PORT_P="${{ env.TEST_PORT_P }}"
243246
export TEST_PORT_R="${{ env.TEST_PORT_R }}"
244247
TESTS_INCLUDED_IN_EXECUTION=( $(grep -v "collected in" <(${{ env.PYTEST_ALIAS }} "tests/${{ inputs.validation-tests-1 }}" ${{ env.PYTEST_PARAMS }} --nic="${TEST_PORT_P},${TEST_PORT_R}" --collect-only -q --no-summary 2>&1)) )
@@ -251,9 +254,14 @@ jobs:
251254
NUMBER_OF_TESTS="${#TESTS_INCLUDED_IN_EXECUTION[@]}"
252255
TESTS_FAIL=()
253256
TESTS_SUCCESS=()
257+
258+
echo "${SUMMARY_MAIN_HEADER} tests (total ${NUMBER_OF_TESTS}) :rocket:\n----------------------------------"
259+
echo "Tests to be executed:\n${TESTS_INCLUDED_IN_EXECUTION[@]}"
260+
254261
echo "## ${SUMMARY_MAIN_HEADER} tests (total ${NUMBER_OF_TESTS}) :rocket:" >> "$GITHUB_STEP_SUMMARY"
255262
echo "| ❌/✅ | Collected Test | Started | Ended | Took (s) | Result |" >> "$GITHUB_STEP_SUMMARY"
256263
echo "| --- | ---| --- | --- | --- | --- |" >> "$GITHUB_STEP_SUMMARY"
264+
echo "::endgroup::"
257265
258266
for test in ${TESTS_INCLUDED_IN_EXECUTION[@]}; do
259267
echo "::group::${test}"
@@ -313,11 +321,16 @@ jobs:
313321
sudo killall -SIGINT pytest || true
314322
sudo killall -SIGINT MtlManager || true
315323
324+
- name: 'cleanup: Create archive with logs from execution'
325+
if: always()
326+
working-directory: tests/validation
327+
run: |
328+
sudo tar -czf "validation-execution-logs.tar.gz" "./logs"
329+
sudo rm -rf "./logs"
330+
316331
- name: 'cleanup: Restore valid owner to repository and directories'
317332
if: always()
318333
run: |
319-
sudo tar -czf "${{ github.workspace }}/tests/validation/validation-execution-logs.tar.gz" "${{ github.workspace }}/tests/validation/logs"
320-
sudo rm -rf "${{ github.workspace }}/tests/validation/logs"
321334
sudo chown -R "${USER}" "$(pwd)"
322335
323336
- name: 'cleanup: Bind pf to kernel driver'
@@ -332,7 +345,7 @@ jobs:
332345
if: always()
333346
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
334347
with:
335-
name: 'validation-execution-logs'
348+
name: 'validation-execution-logs.tar.gz'
336349
path: '${{ github.workspace }}/tests/validation/validation-execution-logs.tar.gz'
337350

338351
- name: 'cleanup: Generate runner summary'

0 commit comments

Comments
 (0)