Fix: DPDK build script undefined behavior

The DPDK build script was using git to patch the DPDK repo inside
the MTL repository, which was causing undefined behavior.
Switch to patch to ensure this always works and add help for
UX.

Author: DawidWesierski4

.github/scripts/setup_environment.sh

@@ -303,7 +303,7 @@ if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
 
 	if [ "${SETUP_BUILD_AND_INSTALL_DPDK}" == "1" ]; then
 		echo "$STEP DPDK build and install"
-		bash "${root_folder}/script/build_dpdk.sh"
+		bash "${root_folder}/script/build_dpdk.sh" -f
 		STEP=$((STEP + 1))
 	fi
 

.gitignore

@@ -85,7 +85,8 @@ mtl_system_status_*
 *.pcm
 *.wav
 script/ice-*
-script/dpdk
+script/dpdk-*
+script/*.zip*
 script/xdp-tools
 
 #Generated documentation

script/build_dpdk.sh

@@ -12,34 +12,73 @@ script_folder=${script_path/$script_name/}
 . "${script_folder}/common.sh"
 cd "${script_folder}" || exit 1
 
-set -x
+show_help() {
+	cat <<EOF
+Usage: $script_name [OPTIONS] [DPDK_VERSION]
 
-if [ -n "$1" ]; then
-	DPDK_VER=$1
-fi
-dpdk_folder="dpdk_${DPDK_VER}"
+Build and install DPDK with MTL patches.
+
+OPTIONS:
+	-f			Force rebuild (removes existing dpdk folder if present)
+	-h			Show this help message
+	-v VERSION	Specify DPDK version to build
+
+	EXAMPLES:
+		$script_name					# Build default DPDK version
+		$script_name -v					# Build specific DPDK version
+		$script_name -f -v 23.11		# Force rebuild of DPDK 23.11
+EOF
+}
+
+FORCE=0
+while getopts "fhv:" opt; do
+	case $opt in
+	f)
+		FORCE=1
+		;;
+	v)
+		DPDK_VER="$OPTARG"
+		;;
+	h)
+		show_help
+		exit 0
+		;;
+	*)
+		show_help
+		exit 1
+		;;
+	esac
+done
+shift $((OPTIND - 1))
+
+dpdk_folder="dpdk-${DPDK_VER}"
 
 (return 0 2>/dev/null) && sourced=1 || sourced=0
 
 if [ "$sourced" -eq 0 ]; then
 	echo "DPDK version: $DPDK_VER"
 
+	if [ $FORCE -eq 1 ] && [ -d "$dpdk_folder" ]; then
+		echo "Force rebuild enabled. Removing existing '$dpdk_folder' directory."
+		rm -rf "$dpdk_folder"
+	fi
+
 	if [ ! -d "$dpdk_folder" ]; then
-		# check out dpdk code
 		echo "Clone DPDK source code"
-		git clone https://github.com/DPDK/dpdk.git "$dpdk_folder"
-	fi
+		wget https://github.com/DPDK/dpdk/archive/refs/tags/v"${DPDK_VER}".zip
+		unzip v"${DPDK_VER}".zip
 
-	cd "$dpdk_folder" || exit 1
-	git checkout v"$DPDK_VER"
-	if git switch -c v"$DPDK_VER"_kahawai_build 2>/dev/null; then
-		git am ../../patches/dpdk/"$DPDK_VER"/*.patch
+		cd "$dpdk_folder" || exit 1
+		for patch_file in ../../patches/dpdk/"$DPDK_VER"/*.patch; do
+			patch -p1 -i "$patch_file"
+		done
 	else
-		echo "Branch v${DPDK_VER}_kahawai_build already exists."
-		echo "Skipping patch application assuming it has been applied before."
+		echo "DPDK source code already exists."
+		echo "To rebuild, please remove the '$dpdk_folder' directory and run this script again."
+		exit 0
 	fi
 
-	# build and install dpdk now
+	echo "Build and install DPDK now"
 	meson build
 	ninja -C build
 	cd build