Skip to content

Commit 6ac463d

Browse files
authored
Fix: Remove unsupported 720p resolution from tests (#1076)
- Add disclaimer about 720p in docs. - The 720p resolution is not supported by MTL for v210 at the moment. This is a MTL bug, but the GStreamer plugin does not need to support it. Signed-off-by: Kasiewicz, Marek <[email protected]>
1 parent 31c21a1 commit 6ac463d

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

ecosystem/gstreamer_plugin/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,14 @@ Video plugins for MTL that are able to send, receive synchronous video via the M
159159
The `mtl_st20p_tx` plugin supports the following pad capabilities:
160160

161161
- **Formats**: `v210`, `I422_10LE`
162-
- **Width Range**: 64 to 16384
162+
- **Width Range**: 64 to 16384*
163163
- **Height Range**: 64 to 8704
164164
- **Framerate Range**: `2398/100`, `24`, `25`, `2997/100`, `30`, `50`, `5994/100`, `60`, `100`,
165165
`11988/100`, `120`
166166

167+
\* Resolution width for v210 format has to be divisible by 3, so the plugin does not support 720p and 1440p.
168+
To be fixed in the future.
169+
167170
[More information about GStreamer capabilities (GstCaps)](https://gstreamer.freedesktop.org/documentation/gstreamer/gstcaps.html)
168171

169172
**Arguments**

tests/validation/tests/single/gstreamer/video_resolution/test_video_resolution.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import tests.Engine.GstreamerApp as gstreamerapp
88
import tests.Engine.media_creator as media_create
99
from tests.Engine.media_files import yuv_files
10+
from tests.xfail import SDBQ1971_conversion_v210_720p_error
1011

1112

1213
@pytest.mark.parametrize("file", yuv_files.keys())
@@ -15,10 +16,17 @@ def test_video_resolutions(
1516
media,
1617
nic_port_list,
1718
file,
19+
request,
1820
):
1921
video_file = yuv_files[file]
2022
video_file["format"] = "v210"
2123

24+
SDBQ1971_conversion_v210_720p_error(
25+
video_format=video_file["format"],
26+
resolution_width=video_file["height"],
27+
request=request,
28+
)
29+
2230
input_file_path = media_create.create_video_file(
2331
width=video_file["width"],
2432
height=video_file["height"],

tests/validation/tests/xfail.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,14 @@ def SDBQ1002_pg_format_error_check(video_format: str, pg_format: str, request):
2626
"XFAIL: SDBQ-1002 - Video, i720p50fps with V210 pg_format Error: tv_frame_free_cb",
2727
request,
2828
)
29+
30+
31+
def SDBQ1971_conversion_v210_720p_error(
32+
video_format: str, resolution_width: int, request
33+
):
34+
if video_format == "v210" and resolution_width == 720:
35+
add_issue(
36+
"XFAIL: SDBQ-1971 - Conversion from v210 format does not work on 720p",
37+
request,
38+
)
39+
assert False

0 commit comments

Comments
 (0)