Ci: Ensure required tasks always run (#1314)

Instead of skipping jobs, we exit immediately when they're not needed.
This prevents PRs from being blocked by required jobs that don't run.

Author: DawidWesierski4

.github/path_filters.yml

@@ -53,8 +53,10 @@ ubuntu_build: &ubuntu_build
   - *docker
   - *ecosystem
 
-linux_gtest: &linux_gtest
+linux_tests: &linux_tests
+  - .github/scripts/gtest.sh
   - .github/workflows/gtest-bare-metal.yml
+  - .github/workflows/smoke-tests.yml
   - '.github/workflows/upl*'
   - 'tests/unittest/*'
   - *ice_build

.github/workflows/base_build.yml

@@ -50,10 +50,10 @@ jobs:
         id: filter
         with:
           filters: .github/path_filters.yml
-  
+
   ubuntu-build:
     needs: changes
-    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' && needs.changes.outputs.ubuntu_build == 'true' }}
+    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' }}
     runs-on: ubuntu-22.04
     timeout-minutes: 60
     steps:
@@ -65,17 +65,19 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Build Release
+        if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
         run: sudo -E .github/scripts/setup_environment.sh
 
       - name: 'upload release build artifacts'
+        if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
         uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
         with:
           name: mtl-release-bin
           path: '${{ github.workspace }}/build/'
 
   ubuntu-ebpf-xdp-build:
     needs: changes
-    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' && needs.changes.outputs.ubuntu_build == 'true' }}
+    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' }}
     runs-on: ubuntu-22.04
     timeout-minutes: 60
     steps:
@@ -87,6 +89,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: ebpf-xdp build
+        if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
         run: sudo -E .github/scripts/setup_environment.sh
         env:
           SETUP_BUILD_AND_INSTALL_EBPF_XDP: 1

.github/workflows/docker_build.yml

@@ -39,7 +39,6 @@ jobs:
 
   ubuntu-docker-build:
     needs: changes
-    if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
     runs-on: ubuntu-22.04
     timeout-minutes: 120
     permissions:
@@ -71,6 +70,7 @@ jobs:
           password: "${{ secrets.GITHUB_TOKEN }}"
 
       - name: Build image
+        if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
         uses: docker/build-push-action@14487ce63c7a62a4a324b0bfb37086795e31c6c1 # v6.16.0
         with:
           push: "${{ env.DOCKER_REGISTRY_LOGIN == 'true' && steps.dockerLoginStep.outcome == 'SUCCESS' && github.ref == 'refs/heads/main' }}"
@@ -122,6 +122,7 @@ jobs:
           password: "${{ secrets.GITHUB_TOKEN }}"
 
       - name: Build manager image
+        if: ${{ needs.changes.outputs.ubuntu_build == 'true' }}
         uses: docker/build-push-action@14487ce63c7a62a4a324b0bfb37086795e31c6c1 # v6.16.0
         with:
           push: "${{ env.DOCKER_REGISTRY_LOGIN == 'true' && steps.dockerLoginStep.outcome == 'SUCCESS' && github.ref == 'refs/heads/main' }}"

.github/workflows/gtest-bare-metal.yml

@@ -31,7 +31,7 @@ jobs:
     permissions:
       pull-requests: read
     outputs:
-      changed: ${{ steps.filter.outputs.linux_gtest == 'true' }}
+      changed: ${{ steps.filter.outputs.linux_tests == 'true' }}
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
@@ -42,7 +42,7 @@ jobs:
 
   run-gtest-tests:
     needs: gtest-check-for-changes
-    if: github.repository == 'OpenVisualCloud/Media-Transport-Library' && (needs.gtest-check-for-changes.outputs.changed == 'true' || github.event_name == 'workflow_dispatch')
+    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' }}
     strategy:
       matrix:
         nic:
@@ -53,16 +53,19 @@ jobs:
     runs-on: ${{ matrix.nic }}
     steps:
       - name: Harden Runner
+        if: ${{ needs.gtest-check-for-changes.outputs.changed == 'true' && github.event_name != 'workflow_dispatch' }}
         uses: step-security/harden-runner@6c439dc8bdf85cadbbce9ed30d1c7b959517bc49 # v2.12.2
         with:
           egress-policy: audit
 
       - name: Checkout MTL
+        if: ${{ needs.gtest-check-for-changes.outputs.changed == 'true' && github.event_name != 'workflow_dispatch' }}
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           ref: '${{ inputs.branch-to-checkout || github.sha || github.ref }}'
 
       - name: Install the build dependency
+        if: ${{ needs.gtest-check-for-changes.outputs.changed == 'true' && github.event_name != 'workflow_dispatch' }}
         run: |
           sudo apt-get update -y && \
           sudo apt-get install -y \
@@ -76,6 +79,7 @@ jobs:
           sudo apt-get autoremove -y
 
       - name: Build
+        if: ${{ needs.gtest-check-for-changes.outputs.changed == 'true' && github.event_name != 'workflow_dispatch' }}
         run: |
           sudo su && ./build.sh
           sudo ldconfig
@@ -85,6 +89,7 @@ jobs:
           sudo dmesg | grep "Intel(R) Ethernet Connection .* version Kahawai.*"
 
       - name: run gtest bare metal
+        if: ${{ needs.gtest-check-for-changes.outputs.changed == 'true' && github.event_name != 'workflow_dispatch' }}
         env:
           NIGHTLY: 0
         run: sudo -E "${{ github.workspace }}/.github/scripts/gtest.sh"

.github/workflows/smoke-tests.yml

@@ -12,7 +12,23 @@ on:
 permissions:
   contents: read
 jobs:
+  smoke-check-for-changes:
+    runs-on: ubuntu-22.04
+    permissions:
+      pull-requests: read
+    outputs:
+      changed: ${{ steps.filter.outputs.linux_tests == 'true' }}
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v2
+        id: filter
+        with:
+          filters: .github/path_filters.yml
+
   run-smoke-tests:
+    needs: smoke-check-for-changes
+    if: ${{ github.repository == 'OpenVisualCloud/Media-Transport-Library' }}
     strategy:
       matrix:
         nic:
@@ -24,26 +40,31 @@ jobs:
     timeout-minutes: 720
     steps:
       - name: 'preparation: Harden Runner'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         uses: step-security/harden-runner@6c439dc8bdf85cadbbce9ed30d1c7b959517bc49 # v2.12.2
         with:
           egress-policy: audit
       - name: 'preparation: Checkout MTL'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           ref: '${{ github.ref }}'
       - uses: ./.github/actions/build
       - name: 'installation: Install pipenv environment'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         working-directory: tests/validation
         id: pipenv-install
         run: |
           python3 -m venv .venv
           source .venv/bin/activate
           pip install -r requirements.txt
       - name: Create session ID
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           runner_name=${{ runner.name }}
           echo "SESSION_ID=${runner_name##*-}" >> "$GITHUB_ENV"
       - name: Set PCI device env variable
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           if [ "${{ matrix.nic }}" = "e810" ]; then
             echo "PCI_DEVICE=8086:1592" >> "$GITHUB_ENV"
@@ -53,6 +74,7 @@ jobs:
             echo "PCI_DEVICE=8086:12d2" >> "$GITHUB_ENV"
           fi
       - name: Generate test framework config files
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         working-directory: tests/validation/configs
         run: |
           python3 gen_config.py \
@@ -64,6 +86,7 @@ jobs:
             --username ${{ secrets.RUNNER_USERNAME }} \
             --key_path ${{ secrets.RUNNER_KEY_PATH }}
       - name: 'preparation: Evaluate choosen validation-test-port-p and validation-test-port-r'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           eval "export TEST_PORT_P=TEST_VF_PORT_P_0"
           eval "export TEST_PORT_R=TEST_VF_PORT_P_1"
@@ -72,30 +95,35 @@ jobs:
           echo "TEST_PORT_P=${TEST_PORT_P}"
           echo "TEST_PORT_R=${TEST_PORT_R}"
       - name: 'preparation: Kill MtlManager and pytest routines'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           sudo killall -SIGINT pipenv || true
           sudo killall -SIGINT pytest || true
           sudo killall -SIGINT MtlManager || true
       - name: 'preparation: Create VFs'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           sudo rmmod irdma || true
           sudo ./script/nicctl.sh create_vf "${TEST_PF_PORT_P}" || true
           sudo ./script/nicctl.sh create_vf "${TEST_PF_PORT_R}" || true
       - name: 'preparation: Start MtlManager at background'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           sudo MtlManager &
       - name: 'execution: Run validation-bare-metal tests in virtual environment'
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           tests/validation/.venv/bin/python3 -m pytest --topology_config=tests/validation/configs/topology_config.yaml --test_config=tests/validation/configs/test_config.yaml -m smoke  --template=html/index.html --report=report.html
       - name: "upload report"
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         id: upload-report
         uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
         with:
           name: smoke-test-report-${{ matrix.nic }}
           path: |
             report.html
       - name: "Add report to summary"
-        if: always()
+        if: ${{ needs.smoke-check-for-changes.outputs.changed == 'true' }}
         run: |
           {
             echo "## Smoke Tests Report"