Fix: FFmpeg build script undefined behavior

FFmpeg build script was using 'git am' to apply
patches, which lead to undefined behavior if
the script was already running in a directory with
git or where patches were already applied.

Remove the need for git altogether to avoid
future issues.

Author: DawidWesierski4

.github/actions/build/action.yml

@@ -40,7 +40,9 @@ runs:
             gstreamer1.0-tools \
             gstreamer1.0-libav \
             libgstreamer1.0-dev \
-            libgstreamer-plugins-base1.0-dev
+            libgstreamer-plugins-base1.0-dev \
+            patch \
+            unzip
       shell: bash
     - name: 'installation: Build mtl'
       run: |

.github/scripts/setup_environment.sh

@@ -175,7 +175,9 @@ function setup_ubuntu_install_dependencies() {
 	if [ "${ECOSYSTEM_BUILD_AND_INSTALL_FFMPEG_PLUGIN}" == "1" ]; then
 		echo "Installing FFMPEG dependencies"
 		apt install -y \
-			nasm
+			nasm \
+			unzip \
+			patch
 	fi
 
 	if [ "${ECOSYSTEM_BUILD_AND_INSTALL_GSTREAMER_PLUGIN}" == "1" ]; then

.gitignore

@@ -100,11 +100,11 @@ _temp*
 gpu_offline_install
 
 # Ecosystem
-script/FFmpeg
+FFmpeg-release-*
 script/dpdk_*
 ecosystem/librist/librsit
 ecosystem/msdk/MediaSDK
 tools/readpcap/readpcap_*
 swig
-openh264
+openh264*
 level-zero-*

ecosystem/ffmpeg_plugin/build.sh

@@ -5,16 +5,23 @@
 
 set -e
 
-# Default values
-ffmpeg_ver="7.0"
 enable_gpu=false
 script_path="$(dirname "$(readlink -f "$0")")"
+VERSIONS_ENV_PATH="$(dirname "$(readlink -qe "${BASH_SOURCE[0]}")")/../../versions.env"
+
+if [ -f "$VERSIONS_ENV_PATH" ]; then
+	# shellcheck disable=SC1090
+	. "$VERSIONS_ENV_PATH"
+else
+	echo -e "Error: versions.env file not found at $VERSIONS_ENV_PATH"
+	exit 1
+fi
 
 # Help message function
 usage() {
 	echo "Usage: $0 [options]"
 	echo "Options:"
-	echo "  -v <version>    Specify the FFmpeg version to build (default is $ffmpeg_ver)"
+	echo "  -v <version>    Specify the FFmpeg version to build (default is $FFMPEG_VERSION)"
 	echo "  -g              Enable GPU direct mode during compilation"
 	echo "  -h              Display this help and exit"
 }
@@ -23,7 +30,7 @@ usage() {
 while getopts ":v:hg" opt; do
 	case "${opt}" in
 	v)
-		ffmpeg_ver=${OPTARG}
+		FFMPEG_VERSION=${OPTARG}
 		;;
 	g)
 		enable_gpu=true
@@ -45,23 +52,47 @@ while getopts ":v:hg" opt; do
 done
 
 build_openh264() {
-	rm -rf openh264
-	git clone https://github.com/cisco/openh264.git
-	cd openh264
-	git checkout openh264v2.4.0
+	if command -v pkg-config >/dev/null 2>&1; then
+		if pkg-config --exists openh264; then
+			echo "openh264 is already installed (detected by pkg-config). Skipping build."
+			return
+		fi
+	else
+		echo "Warning: pkg-config not found. Skipping openh264 installation check."
+	fi
+
+	if [ -d "openh264-openh264v2.4.0" ]; then
+		echo "openh264v2.4.0 directory already exists. Removing it to ensure a clean build."
+		rm -rf openh264-openh264v2.4.0
+	fi
+
+	wget https://github.com/cisco/openh264/archive/refs/heads/openh264v2.4.0.zip
+	unzip openh264v2.4.0.zip && rm -f openh264v2.4.0.zip
+	cd openh264-openh264v2.4.0
 	make -j "$(nproc)"
 	sudo make install
 	sudo ldconfig
 	cd ../
 }
 
 build_ffmpeg() {
-	rm -rf FFmpeg
-	git clone https://github.com/FFmpeg/FFmpeg.git
-	cd FFmpeg
-	git checkout release/"$ffmpeg_ver"
+	if [ -d "FFmpeg-release-${FFMPEG_VERSION}" ]; then
+		echo "FFmpeg directory already exists. Removing it to ensure a clean build."
+		rm -rf "FFmpeg-release-${FFMPEG_VERSION}"
+	fi
+
+	wget "https://github.com/FFmpeg/FFmpeg/archive/refs/heads/release/${FFMPEG_VERSION}.zip"
+	unzip "${FFMPEG_VERSION}.zip" && rm -f "${FFMPEG_VERSION}.zip"
+
+	cd "FFmpeg-release-${FFMPEG_VERSION}"
 	cp -f "$script_path"/mtl_* ./libavdevice/
-	git am "$script_path"/"$ffmpeg_ver"/*.patch
+
+	for patch_file in "$script_path"/"$FFMPEG_VERSION"/*.patch; do
+		if [ -f "$patch_file" ]; then
+			echo "Applying patch: $(basename "$patch_file")"
+			patch -p1 <"$patch_file"
+		fi
+	done
 
 	if [ "$enable_gpu" = true ]; then
 		echo "Building with MTL_GPU_DIRECT_ENABLED"
@@ -80,4 +111,4 @@ build_ffmpeg() {
 build_openh264
 build_ffmpeg
 
-echo "Building ffmpeg $ffmpeg_ver plugin is finished"
+echo "Building ffmpeg $FFMPEG_VERSION plugin is finished"

versions.env

@@ -4,6 +4,7 @@ ICE_DMID=859252
 ONE_API_GPU_VER=1.22.3
 LIBRIST_COMMIT_VER=9f09a3defd6e59839aae3e3b7b5411213fa04b8a
 RUST_HOOK_CARGO_VER=0.5.5
+FFMPEG_VERSION=7.0
 
 DPDK_REPO=https://github.com/dpdk/dpdk/archive/refs/tags/v${DPDK_VER}.tar.gz
 ICE_REPO=https://downloadmirror.intel.com/${ICE_DMID}/ice-${ICE_VER}.tar.gz