Refactor: Change log level from notice to debug for TX statistics and update interlace mismatch as well as test coverage description

Author: moleksy

lib/src/st2110/pipeline/st40_pipeline_tx.c

@@ -366,11 +366,11 @@ static int tx_st40p_stat(void* priv) {
                          st40p_tx_frame_stat_name_short[i], status_counts[i]);
     }
   }
-  notice("TX_st40p(%d,%s), framebuffer queue: %s\n", ctx->idx, ctx->ops_name, status_str);
+  dbg("TX_st40p(%d,%s), framebuffer queue: %s\n", ctx->idx, ctx->ops_name, status_str);
 
-  notice("TX_st40p(%d), frame get try %d succ %d, put %d, drop %d\n", ctx->idx,
-         ctx->stat_get_frame_try, ctx->stat_get_frame_succ, ctx->stat_put_frame,
-         ctx->stat_drop_frame);
+  dbg("TX_st40p(%d), frame get try %d succ %d, put %d, drop %d\n", ctx->idx,
+      ctx->stat_get_frame_try, ctx->stat_get_frame_succ, ctx->stat_put_frame,
+      ctx->stat_drop_frame);
 
   ctx->stat_get_frame_try = 0;
   ctx->stat_get_frame_succ = 0;
@@ -742,7 +742,7 @@ int st40p_tx_get_session_stats(st40p_tx_handle handle, struct st40_tx_user_stats
                          st40p_tx_frame_stat_name_short[i], status_counts[i]);
     }
   }
-  notice("TX_st40p(%d,%s), framebuffer queue: %s\n", ctx->idx, ctx->ops_name, status_str);
+  dbg("TX_st40p(%d,%s), framebuffer queue: %s\n", ctx->idx, ctx->ops_name, status_str);
 
   return st40_tx_get_session_stats(ctx->transport, stats);
 }

lib/src/st2110/st_rx_ancillary_session.c

@@ -146,25 +146,6 @@ static int rx_ancillary_session_handle_pkt(struct mtl_main_impl* impl,
       info("%s(%d,%d), detected %s stream (F=0x%x)\n", __func__, s->idx, s_port,
            pkt_interlaced ? "interlaced" : "progressive", f_bits);
     }
-  } else {
-    /* Enforce interlace expectation vs header F bits */
-    if (ops->interlaced) {
-      /* Expect interlaced: drop progressive/unspecified (0b00) */
-      if (!pkt_interlaced) {
-        ST40_FUZZ_LOG("%s(%d,%d), drop progressive F=0 when interlaced expected\n",
-                      __func__, s->idx, s_port);
-        ST_SESSION_STAT_INC(s, port_user_stats, stat_pkts_wrong_interlace_dropped);
-        return -EINVAL;
-      }
-    } else {
-      /* Expect progressive: drop interlaced flags (0b10 or 0b11) */
-      if (pkt_interlaced) {
-        ST40_FUZZ_LOG("%s(%d,%d), drop interlaced F=0x%x when progressive expected\n",
-                      __func__, s->idx, s_port, f_bits);
-        ST_SESSION_STAT_INC(s, port_user_stats, stat_pkts_wrong_interlace_dropped);
-        return -EINVAL;
-      }
-    }
   }
 
   /* Count field polarity when interlaced frames are accepted */

tests/validation/mtl_engine/GstreamerApp.py

@@ -873,13 +873,12 @@ def _summarize_frame_info(lines: list[str]) -> Optional[str]:
         logger.info("RX interlace auto-detect enabled; skipping mismatch check")
     elif tx_interlaced is not None and rx_interlaced is not None:
         if tx_interlaced != rx_interlaced:
-            logger.info(
+            logger.warning(
                 "Interlace flag mismatch detected (tx_interlaced=%s, rx_interlaced=%s). "
-                "Failing test before file compare.",
+                "Continuing to file compare.",
                 tx_interlaced,
                 rx_interlaced,
             )
-            return False
     if skip_file_compare:
         logger.info("Skipping file comparison per caller request")
         return True

tests/validation/tests/single/gstreamer/anc_format/test_anc_format.py

@@ -1520,16 +1520,15 @@ def test_st40i_interlace_flag_mismatch(
     media_file,
 ):
     """
-    Negative coverage for mismatched interlace flags: TX sends interlaced while
-    RX expects progressive, validating that the pipeline signals failure rather
-    than accepting bad cadence.
+    Mismatched interlace flags: TX sends interlaced while RX expects progressive,
+    validating the pipeline still completes and the mismatch is surfaced via logs.
 
     .. rubric:: Purpose
-    Negative coverage where TX is interlaced and RX expects progressive.
+    Coverage where TX is interlaced and RX expects progressive.
 
     .. rubric:: Pass Criteria
-    - GStreamer pipeline returns False, signalling the mismatch is detected.
-    - No unexpected RX readiness or payload is produced.
+    - GStreamer pipeline returns True and completes the run.
+    - Logs may warn about interlace mismatch, but payload capture completes.
 
     :param hosts: Mapping of available hosts for running pipelines remotely.
     :param build: Compiled GStreamer binaries/scripts used for TX/RX.
@@ -1582,7 +1581,7 @@ def test_st40i_interlace_flag_mismatch(
 
     expectation = (
         f"Interlace mismatch TX interlaced/RX progressive @ {fps}fps "
-        f"framebuff={framebuff} must fail"
+        f"framebuff={framebuff} completes with warning"
     )
 
     try:
@@ -1599,7 +1598,7 @@ def test_st40i_interlace_flag_mismatch(
                 sleep_interval=5,
                 log_frame_info=True,
             )
-            assert not result, "Interlace mismatch unexpectedly succeeded"
+            assert result, "Interlace mismatch unexpectedly failed"
     finally:
         media_create.remove_file(input_file_path, host=host)
         media_create.remove_file(output_file_path, host=host)