Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 251cb8b

Browse files
Austin-Hutianjunwork
authored andcommitted
Remove redundant memory allocation in LcuParamsCtor(). (#417)
Because the lcuParamsArray of an SCS object will be allocated through ResourceCoordinationKernel()->LcuParamsInit() later. With it removed, about 4.5MB memory ((EB_SequenceControlSetPoolInitCount + 1) * sizeof(LcuParams_t) * 146 * 80) can be saved. Signed-off-by: Austin Hu <[email protected]>
1 parent 1a0b2f6 commit 251cb8b

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

Source/Lib/Codec/EbSequenceControlSet.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,6 @@ EB_ERRORTYPE EbSequenceControlSetCtor(
167167
EbUnRegUserDataSEICtor(
168168
&sequenceControlSetPtr->unRegUserDataSeiPtr);
169169

170-
// Initialize LCU params
171-
LcuParamsCtor(
172-
sequenceControlSetPtr);
173-
174170
sequenceControlSetPtr->maxDpbSize = 0;
175171

176172
return EB_ErrorNone;
@@ -230,17 +226,6 @@ EB_ERRORTYPE EbSequenceControlSetInstanceCtor(
230226

231227
return EB_ErrorNone;
232228
}
233-
234-
235-
extern EB_ERRORTYPE LcuParamsCtor(
236-
SequenceControlSet_t *sequenceControlSetPtr) {
237-
238-
EB_ERRORTYPE return_error = EB_ErrorNone;
239-
240-
EB_MALLOC(LcuParams_t*, sequenceControlSetPtr->lcuParamsArray, sizeof(LcuParams_t) * ((MAX_PICTURE_WIDTH_SIZE + sequenceControlSetPtr->lcuSize - 1) / sequenceControlSetPtr->lcuSize) * ((MAX_PICTURE_HEIGHT_SIZE + sequenceControlSetPtr->lcuSize - 1) / sequenceControlSetPtr->lcuSize), EB_N_PTR);
241-
return return_error;
242-
}
243-
244229

245230
extern EB_ERRORTYPE LcuParamsInit(
246231
SequenceControlSet_t *sequenceControlSetPtr) {

Source/Lib/Codec/EbSequenceControlSet.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,11 +230,6 @@ extern EB_ERRORTYPE CopySequenceControlSet(
230230

231231
extern EB_ERRORTYPE EbSequenceControlSetInstanceCtor(
232232
EbSequenceControlSetInstance_t **objectDblPtr);
233-
234-
235-
236-
extern EB_ERRORTYPE LcuParamsCtor(
237-
SequenceControlSet_t *sequenceControlSetPtr);
238233

239234
extern EB_ERRORTYPE LcuParamsInit(
240235
SequenceControlSet_t *sequenceControlSetPtr);

0 commit comments

Comments
 (0)