Why is the ffmpeg patch not already in ffmpeg master?

[thesn10]

I can install SVT-AV1 without having to manually patch ffmpeg. So why isnt this the case with SVT-VP9 already?

[1480c1]

It requires a lot of effort and cleanup to upstream the patch and we do not have the resources and time to do so at this moment.

[rathann]

Looks like somebody asked about this 2 years ago already: https://trac.ffmpeg.org/ticket/7914 .

[joeyparrish]

I'm in the process of updating the patch for ffmpeg n6.0 now. I'll post a link here if I get it working. I had to make some adjustments that I'm not 100% certain about.

[joeyparrish]

I'm giving up for now. I got it to build, but I get this error:

[0911/173548:ERROR:demuxer.cc(202)] Failed to detect the container type from the buffer: 000000206674797069736F6D0000020069736F6D69736F3669736F326D703431

I don't get a similar error from SVT-AV1.

Here's the patch I'm using.
n6.0-0001-Add-ability-for-ffmpeg-to-run-svt-vp9.patch.txt

My guess is that I messed up the changes to the mkv_write_block() calls. That function changed so much that I was really not sure I was mapping the changes in the patch correctly.

[joeyparrish]

This simplified version has the same issue:

n6.0-0001-Simplified-libsvtvp9.patch.txt

I hope these are a useful starting point for someone who knows more than me about SVT-VP9 and FFmpeg both.

[joeyparrish]

Oh, crap, I was starting from the patch at SVT-VP9 0.30, which has been revised since then. Disregard the above.

[niklaskorz]

The master patch in https://github.com/OpenVisualCloud/SVT-VP9/blob/master/ffmpeg_plugin/master-0001-Add-ability-for-ffmpeg-to-run-svt-vp9.patch is up to date and even applies cleanly to ffmpeg 8.0.
@1480c1 @hassount Could you give some quick feedback on whether you would be ok with a community driven effort of upstreaming your patch?

[1480c1]

I would be okay, but I would prefer if the patch can be brought to a similar standard as SVT-AV1's wrapper.

There are quite a few features missing from this library, like something similar to svtav1-params. As of right now, we can't really spare much resource into getting those features into SVT-VP9.

You could try upstreaming as is after some clean up and get some feedback.