Skip to content

Commit 6644ad4

Browse files
JarbasAlrenovate[bot]coderabbitai[bot]
authored
Release 1.3.5a5 (#42)
* allow OPM 1.X:X * Update release_workflow.yml * Update publish_stable.yml * Update release_workflow.yml * Merge pull request #31 from OpenVoiceOS/renovate/configure Configure Renovate * Increment Version to 1.3.5a1 * Update Changelog * Update dependency python to 3.14 (#32) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Increment Version to 1.3.5a2 * Update Changelog * Update dependency ovos-plugin-manager to v2 (#37) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Increment Version to 1.3.5a3 * Update Changelog * chore!: drop GUI (#39) * chore!: drop GUI * 📝 Add docstrings to `drop_gui` (#40) Docstrings generation was requested by @JarbasAl. * #39 (comment) The following files were modified: * `ovos_PHAL_plugin_network_manager/__init__.py` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Increment Version to 1.3.5a4 * Update Changelog * Update publish_stable.yml * Change Python version to 3.11 in release workflow Updated Python version from 3.14 to 3.11 in the release workflow. * Remove PR merged condition from publish_alpha job Removed conditional check for merged pull requests in the publish_alpha job. * Increment Version to 1.3.5a5 --------- Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2 parents fd87b98 + e1d4e1c commit 6644ad4

32 files changed

+69
-5011
lines changed

.github/workflows/publish_stable.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@ jobs:
1919
if: success() # Ensure this job only runs if the previous job succeeds
2020
runs-on: ubuntu-latest
2121
steps:
22-
- uses: actions/checkout@v2
22+
- uses: actions/checkout@v4
2323
with:
24-
ref: dev
24+
ref: master
2525
fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository.
2626
- name: Setup Python
27-
uses: actions/setup-python@v1
27+
uses: actions/setup-python@v5
2828
with:
29-
python-version: 3.8
29+
python-version: "3.11"
3030
- name: Install Build Tools
3131
run: |
3232
python -m pip install build wheel
@@ -61,12 +61,12 @@ jobs:
6161
if: success() # Ensure this job only runs if the previous job succeeds
6262
runs-on: ubuntu-latest
6363
steps:
64-
- uses: actions/checkout@v2
64+
- uses: actions/checkout@v4
6565
with:
6666
fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository.
6767
ref: master
6868
- name: Push master -> dev
6969
uses: ad-m/github-push-action@master
7070
with:
7171
github_token: ${{ secrets.GITHUB_TOKEN }}
72-
branch: dev
72+
branch: dev

.github/workflows/release_workflow.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: Release Alpha and Propose Stable
22

33
on:
4+
workflow_dispatch:
45
pull_request:
56
types: [closed]
67
branches: [dev]
78

89
jobs:
910
publish_alpha:
10-
if: github.event.pull_request.merged == true
1111
uses: TigreGotico/gh-automations/.github/workflows/publish-alpha.yml@master
1212
secrets: inherit
1313
with:
@@ -23,7 +23,7 @@ jobs:
2323
needs: publish_alpha
2424
runs-on: ubuntu-latest
2525
steps:
26-
- uses: actions/checkout@v2
26+
- uses: actions/checkout@v4
2727
- name: Send message to Matrix bots channel
2828
id: matrix-chat-message
2929
uses: fadenb/matrix-chat-message@v0.0.6
@@ -39,14 +39,14 @@ jobs:
3939
if: success() # Ensure this job only runs if the previous job succeeds
4040
runs-on: ubuntu-latest
4141
steps:
42-
- uses: actions/checkout@v2
42+
- uses: actions/checkout@v4
4343
with:
4444
ref: dev
4545
fetch-depth: 0 # otherwise, there would be errors pushing refs to the destination repository.
4646
- name: Setup Python
47-
uses: actions/setup-python@v1
47+
uses: actions/setup-python@v5
4848
with:
49-
python-version: 3.8
49+
python-version: "3.11"
5050
- name: Install Build Tools
5151
run: |
5252
python -m pip install build wheel
@@ -56,7 +56,7 @@ jobs:
5656
- name: Build Distribution Packages
5757
run: |
5858
python setup.py sdist bdist_wheel
59-
- name: Publish to Test PyPI
59+
- name: Publish to PyPI
6060
uses: pypa/gh-action-pypi-publish@master
6161
with:
6262
password: ${{secrets.PYPI_TOKEN}}
@@ -68,14 +68,14 @@ jobs:
6868
runs-on: ubuntu-latest
6969
steps:
7070
- name: Checkout dev branch
71-
uses: actions/checkout@v3
71+
uses: actions/checkout@v4
7272
with:
7373
ref: dev
7474

7575
- name: Setup Python
76-
uses: actions/setup-python@v2
76+
uses: actions/setup-python@v5
7777
with:
78-
python-version: '3.10'
78+
python-version: '3.11'
7979

8080
- name: Get version from setup.py
8181
id: get_version

CHANGELOG.md

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,40 @@
11
# Changelog
22

3-
## [1.3.4a1](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.4a1) (2024-12-10)
3+
## [1.3.5a4](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.5a4) (2026-03-01)
44

5-
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.3a1...1.3.4a1)
5+
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.5a3...1.3.5a4)
66

77
**Merged pull requests:**
88

9-
- fix:removed\_dialogs [\#29](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/29) ([JarbasAl](https://github.com/JarbasAl))
9+
- chore!: drop GUI [\#39](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/39) ([JarbasAl](https://github.com/JarbasAl))
1010

11-
## [1.3.3a1](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.3a1) (2024-12-10)
11+
## [1.3.5a3](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.5a3) (2025-12-19)
1212

13-
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/V1.3.2...1.3.3a1)
13+
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.5a2...1.3.5a3)
1414

1515
**Merged pull requests:**
1616

17-
- fix:gui pages handling [\#27](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/27) ([JarbasAl](https://github.com/JarbasAl))
17+
- Update dependency ovos-plugin-manager to v2 [\#37](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/37) ([renovate[bot]](https://github.com/apps/renovate))
1818

19-
## [V1.3.2](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/V1.3.2) (2024-11-06)
19+
## [1.3.5a2](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.5a2) (2025-12-19)
2020

21-
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.2...V1.3.2)
21+
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.5a1...1.3.5a2)
22+
23+
**Merged pull requests:**
24+
25+
- Update dependency python to 3.14 [\#32](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/32) ([renovate[bot]](https://github.com/apps/renovate))
26+
27+
## [1.3.5a1](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/1.3.5a1) (2025-12-18)
28+
29+
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/V1.3.4...1.3.5a1)
30+
31+
**Merged pull requests:**
32+
33+
- Configure Renovate [\#31](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/pull/31) ([renovate[bot]](https://github.com/apps/renovate))
34+
35+
## [V1.3.4](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/tree/V1.3.4) (2024-12-10)
36+
37+
[Full Changelog](https://github.com/OpenVoiceOS/ovos-PHAL-plugin-network-manager/compare/1.3.4...V1.3.4)
2238

2339

2440

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ The dbus interface for this plugin is a work in progress. [#15](https://github.c
88
This plugin has the following requirements:
99
- nmcli
1010

11-
It also provides a GUI interface to setup wifi on screen, in this case you also need:
12-
- Plasma Network Manager: https://invent.kde.org/plasma/plasma-nm
1311

1412
# Install
1513

ovos_PHAL_plugin_network_manager/__init__.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from ovos_config import Configuration
66
from ovos_plugin_manager.templates.phal import AdminPlugin, AdminValidator, PHALPlugin, PHALValidator
77
from ovos_utils.log import LOG
8-
from ovos_PHAL_plugin_network_manager.gui import GUISetup
8+
99

1010
# Event Documentation
1111
# ===================
@@ -77,6 +77,15 @@ class NetworkManagerPlugin(PHALPlugin):
7777
validator = NetworkManagerValidator
7878

7979
def __init__(self, bus=None, config=None):
80+
"""
81+
Initialize the NetworkManagerPlugin and register PHAL network event handlers on the message bus.
82+
83+
Registers handlers for network manager events such as scanning, connecting (including open networks), reconnecting, disconnecting, forgetting networks, and querying the currently connected network.
84+
85+
Parameters:
86+
bus: Message bus instance used to subscribe to PHAL events.
87+
config: Optional configuration dictionary or object for plugin initialization.
88+
"""
8089
super().__init__(bus=bus, name="ovos-PHAL-plugin-network-manager", config=config)
8190
# Register Network Manager Events
8291
self.bus.on("ovos.phal.nm.scan", self.handle_network_scan_request)
@@ -86,11 +95,20 @@ def __init__(self, bus=None, config=None):
8695
self.bus.on("ovos.phal.nm.disconnect", self.handle_network_disconnect_request)
8796
self.bus.on("ovos.phal.nm.forget", self.handle_network_forget_request)
8897
self.bus.on("ovos.phal.nm.get.connected", self.handle_network_connected_query)
89-
self.gui_setup = GUISetup(bus=bus) # extra GUI events
9098

9199
# Network Manager Events
92100
def handle_network_scan_request(self, message):
93101
# Scan for networks using Network Manager and build a list of networks found and their security types
102+
"""
103+
Scan for available Wi-Fi networks using Network Manager and emit a completion message with results.
104+
105+
Performs an nmcli rescan and lists SSID and SECURITY fields, then emits an "ovos.phal.nm.scan.complete" Message on the bus with a payload containing a "networks" list. Each list item is a dict with keys:
106+
- "ssid": network SSID string
107+
- "security": security string reported by nmcli
108+
109+
Parameters:
110+
message (Message): Incoming request message (contents are not inspected).
111+
"""
94112
LOG.info("Scanning for networks using nmcli backend")
95113
subprocess.Popen(
96114
['nmcli', 'dev', 'wifi', 'rescan']

0 commit comments

Comments
 (0)