refactor: ovoscope (#691)

moved to the new end2end test framework https://github.com/TigreGotico/ovoscope

drop codecov for self hosted solution

Author: JarbasAl

.coveragerc

@@ -0,0 +1,2 @@
+[run]
+relative_files = true

.github/workflows/coverage.yml

@@ -1,59 +1,36 @@
-name: Run CodeCov
+# .github/workflows/coverage.yml
+name: Post coverage comment
+
 on:
-  push:
-    branches:
-      - dev
-  workflow_dispatch:
+  workflow_run:
+    workflows: ["Run Tests"]
+    types:
+      - completed
 
 jobs:
-  run:
+  test:
+    name: Run tests & display coverage
     runs-on: ubuntu-latest
-    env:
-      PYTHON: "3.11"
+    if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion == 'success'
+    permissions:
+      # Gives the action the necessary permissions for publishing new
+      # comments in pull requests.
+      pull-requests: write
+      # Gives the action the necessary permissions for editing existing
+      # comments (to avoid publishing multiple comments in the same PR)
+      contents: write
+      # Gives the action the necessary permissions for looking up the
+      # workflow that launched this workflow, and download the related
+      # artifact that contains the comment to be published
+      actions: read
     steps:
-    - uses: actions/checkout@master
-    - name: Setup Python
-      uses: actions/setup-python@master
-      with:
-        python-version: "3.11"
-    - name: Install System Dependencies
-      run: |
-        sudo apt-get update
-        sudo apt install python3-dev libssl-dev libfann-dev portaudio19-dev libpulse-dev
-        python -m pip install build wheel
-    - name: Install test dependencies
-      run: |
-          pip install -r requirements/tests.txt
-          pip install ./test/integrationtests/common_query/ovos_tskill_fakewiki
-          pip install ./test/end2end/skill-ovos-hello-world
-          pip install ./test/end2end/skill-ovos-fallback-unknown
-          pip install ./test/end2end/skill-ovos-slow-fallback
-          pip install ./test/end2end/skill-converse_test
-          pip install ./test/end2end/skill-ovos-schedule
-          pip install ./test/end2end/skill-new-stop
-          pip install ./test/end2end/skill-old-stop
-          pip install ./test/end2end/skill-fake-fm
-          pip install ./test/end2end/skill-ovos-fakewiki
-          pip install ./test/end2end/metadata-test-plugin
-    - name: Install core repo
-      run: |
-        pip install -e .[mycroft,deprecated,plugins]
-    - name: Generate coverage report
-      run: |
-        pytest --cov=ovos_core --cov-report xml test/unittests
-        pytest --cov-append --cov=ovos_core --cov-report xml test/end2end
-    - name: Generate coverage report with padatious
-      run: |
-        sudo apt install libfann-dev
-        pip install .[lgpl]
-        pytest --cov-append --cov=ovos_core --cov-report xml test/unittests/skills
-    - name: Upload coverage to Codecov
-      uses: codecov/codecov-action@v3
-      with:
-        token: ${{ secrets.CODECOV_TOKEN }}
-        directory: ./coverage/reports/
-        fail_ci_if_error: true
-        files: ./coverage.xml,!./cache
-        flags: unittests
-        name: codecov-umbrella
-        verbose: true
+      # DO NOT run actions/checkout here, for security reasons
+      # For details, refer to https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
+      - name: Post comment
+        uses: py-cov-action/python-coverage-comment-action@v3
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GITHUB_PR_RUN_ID: ${{ github.event.workflow_run.id }}
+          # Update those if you changed the default values:
+          # COMMENT_ARTIFACT_NAME: python-coverage-comment-action
+          # COMMENT_FILENAME: python-coverage-comment-action.txt

.github/workflows/end2end_tests.yml

@@ -1,31 +1,29 @@
-name: Run UnitTests
+name: Run Tests
 on:
   pull_request:
     branches:
       - dev
     paths-ignore:
       - 'ovos_core/version.py'
-      - 'examples/**'
       - '.github/**'
       - '.gitignore'
       - 'LICENSE'
       - 'CHANGELOG.md'
       - 'MANIFEST.in'
-      - 'readme.md'
+      - 'README.md'
       - 'scripts/**'
   push:
     branches:
-      - master
+      - dev
     paths-ignore:
       - 'ovos_core/version.py'
       - 'requirements/**'
-      - 'examples/**'
       - '.github/**'
       - '.gitignore'
       - 'LICENSE'
       - 'CHANGELOG.md'
       - 'MANIFEST.in'
-      - 'readme.md'
+      - 'README.md'
       - 'scripts/**'
   workflow_dispatch:
 
@@ -34,8 +32,16 @@ jobs:
     strategy:
       max-parallel: 3
       matrix:
-        python-version: ["3.11"]
+        python-version: ["3.11", "3.12"]
     runs-on: ubuntu-latest
+    permissions:
+      # Gives the action the necessary permissions for publishing new
+      # comments in pull requests.
+      pull-requests: write
+      # Gives the action the necessary permissions for pushing data to the
+      # python-coverage-comment-action branch, and for editing existing
+      # comments (to avoid publishing multiple comments in the same PR)
+      contents: write
     timeout-minutes: 35
     steps:
       - uses: actions/checkout@v4
@@ -46,33 +52,26 @@ jobs:
       - name: Install System Dependencies
         run: |
           sudo apt-get update
-          sudo apt install python3-dev swig libssl-dev portaudio19-dev libpulse-dev
+          sudo apt install python3-dev swig libssl-dev portaudio19-dev libpulse-dev libfann-dev
           python -m pip install build wheel uv
-      - name: Install test dependencies
-        run: |
-          uv pip install --system -r requirements/tests.txt
       - name: Install core repo
         run: |
-          uv pip install --system -e .[mycroft,plugins]
-      - name: Run unittests
-        run: |
-          pytest --cov=ovos_core --cov-report xml test/unittests
-      - name: Install padatious
-        run: |
-          sudo apt install libfann-dev
-          uv pip install --system .[lgpl]
-      - name: Run unittests with padatious
+          uv pip install --system -e .[mycroft,plugins,skills-essential,lgpl,test]
+      - name: Run tests
         run: |
-          pytest --cov-append --cov=ovos_core --cov-report xml test/unittests
-      - name: Upload coverage
-        env:
-          CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
-        uses: codecov/codecov-action@v3
+          pytest --cov=ovos_core --cov-report xml test/
+
+      - name: Coverage comment
+        id: coverage_comment
+        uses: py-cov-action/python-coverage-comment-action@v3
+        with:
+          GITHUB_TOKEN: ${{ github.token }}
+
+      - name: Store Pull Request comment to be posted
+        uses: actions/upload-artifact@v4
+        if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
         with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          directory: ./coverage/reports/
-          fail_ci_if_error: true
-          files: ./coverage.xml,!./cache
-          flags: unittests
-          name: codecov-unittests
-          verbose: true
+          # If you use a different name, update COMMENT_ARTIFACT_NAME accordingly
+          name: python-coverage-comment-action
+          # If you use a different name, update COMMENT_FILENAME accordingly
+          path: python-coverage-comment-action.txt

.github/workflows/integration_tests.yml

@@ -5,31 +5,23 @@ dev.env
 *.pyc
 *.swp
 *~
-mimic
-/skills
-pocketsphinx-python
 *.egg-info/
 build
 dist
 tornado.web
 tornado.ioloop
-mycroft/__version__.py
-scripts/logs/*
-logs/*
-.coverage
-/htmlcov
-test/audio_accuracy/data
-scripts/*.screen
-doc/_build/
 .installed
 .mypy_cache
 .vscode
 .theia
 .venv/
 
 # Created by unit tests
-test/unittests/skills/test_skill/settings.json
-test_conf.json
+coverage.xml
+pytest.ini
+.coverage
+.testmondata*
 .pytest_cache/
+/htmlcov
 /.gtm/
 !/.ruff_cache/

.github/workflows/unit_tests.yml

@@ -6,7 +6,7 @@ combo-lock>=0.2.2, <0.4
 padacioso>=1.0.0, <2.0.0
 ovos-adapt-parser>=1.0.5, <2.0.0
 ovos_ocp_pipeline_plugin>=1.0.10, <2.0.0
-ovos-common-query-pipeline-plugin>=1.0.5, <2.0.0
+ovos-common-query-pipeline-plugin>=1.0.5,<2.0.0
 ovos-persona>=0.4.4,<1.0.0
 
 ovos-utils[extras]>=0.6.0,<1.0.0