-
-
Notifications
You must be signed in to change notification settings - Fork 5
Description
We identified inconsistent module versions in QML files (QtQuick, QtQuick.Controls, QtQuick.Layouts, org.kde.kirigami). This issue is to track their standardization in the repository. \n\nReferences:\n- Pull Request: https://github.com/OpenVoiceOS/ovos-gui/pull/70\n- Comment: https://github.com/OpenVoiceOS/ovos-gui/pull/70#discussion_r1898138474\n\n@JarbasAl
π‘ Codebase verification
Inconsistent module versions detected across QML files
The codebase shows varying versions for the same Qt modules across different files:
- QtQuick: varies between 2.4, 2.9, and 2.12
- QtQuick.Controls: varies between 2.0 and 2.12
- QtQuick.Layouts: varies between 1.4 and 1.12
- org.kde.kirigami: varies between 2.4, 2.10, and 2.11
Specific files with newer versions that could guide standardization:
SYSTEM_Loading.qml,SYSTEM_Status.qml,FeatureRequest.qml: Using QtQuick 2.12, QtQuick.Controls 2.12RequestHandler.qml: Using QtQuick.Layouts 1.12SYSTEM_UrlFrame.qml: Using Kirigami 2.11
Consider updating all QML files to use these newer, consistent versions to ensure compatibility and maintainability.
π Analysis chain
Use consistent import versions for better maintenance.
All imports are pinned to specific versions except for QtQuick (which uses version 2.4). Verify if version alignment is needed across all QML modules to avoid potential compatibility issues.
Run a quick sanity check to confirm a consistent and supported set of module versions:
π Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for all import statements, making sure we consistently use versions.
rg 'import QtQuick' -A 2
rg 'import QtQuick.Controls' -A 2
rg 'import org.kde.kirigami' -A 2
Length of output: 10308