-
-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
Problem
The deregister_ocp_keyword method in OVOSCommonPlaybackSkill is currently incomplete and does not properly remove entities from internal data structures (ocp_matchers and _ocp_ents). This could lead to memory leaks as entities accumulate without proper cleanup.
Current Behavior
The method currently only passes without removing entities:
- Entities remain in
ocp_matchersdictionary - Entities remain in
_ocp_entsdictionary - No local cleanup is performed
Expected Behavior
The method should properly clean up registered entities from internal data structures, even if upstream deregistration is not yet supported.
Context
This issue was identified during code review of PR #365.
References:
- PR: fix: ocp skills #365
- Comment: fix: ocp skills #365 (comment)
- Requested by: @JarbasAl
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels